Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Color 5: Relative Color Syntax #841

Closed
svgeesus opened this issue Jul 3, 2023 · 15 comments · Fixed by #915
Closed

CSS Color 5: Relative Color Syntax #841

svgeesus opened this issue Jul 3, 2023 · 15 comments · Fixed by #915

Comments

@svgeesus
Copy link

svgeesus commented Jul 3, 2023

Request for Mozilla Position on an Emerging Web Specification

Other information

@svgeesus
Copy link
Author

svgeesus commented Jul 3, 2023

Oh, relative color syntax is also supported in Lightning CSS, a server-side preprocessor written in Rust:

https://lightningcss.dev/transpilation.html#relative-colors

@svgeesus
Copy link
Author

svgeesus commented Sep 8, 2023

@emilio is there an official position?

@emilio
Copy link
Collaborator

emilio commented Sep 8, 2023

I think we generally like the shape of RCS. cc @tlouw who has looked more into it.

I'd love more tests for the feature because just from a quick look a couple weeks ago Safari doesn't support currentColor in RCS, which seems like a big oversight and apparently nobody noticed?

I'd suggest a positive position, assuming the test-suite improves, and also assuming Tiaan agrees :)

@tiaanl
Copy link
Contributor

tiaanl commented Sep 11, 2023

The spec as it is now looks good. Only thing coming up for me during prototyping was the currectcolor issue, but that has been addressed now.

Implementation for this will start soonish.

@svgeesus
Copy link
Author

@emilio could you review web-platform-tests/wpt#41933 which adds some RCS currentColor tests?

@tiaanl
Copy link
Contributor

tiaanl commented Sep 12, 2023

Having currentcolor in color-valid-relative-color.html would also help to make it clear that parsing and serializing it as specified value is valid.

@svgeesus
Copy link
Author

Good point, I will add it.

@svgeesus
Copy link
Author

Having currentcolor in color-valid-relative-color.html would also help to make it clear that parsing and serializing it as specified value is valid.

Added in web-platform-tests/wpt@9a43e48

@svgeesus
Copy link
Author

@tiaanl could you review web-platform-tests/wpt#41933

@tiaanl
Copy link
Contributor

tiaanl commented Sep 14, 2023

@svgeesus Yup looks great. Thanks!

@svgeesus
Copy link
Author

Okay well please say so as an approving review comment :)

@svgeesus
Copy link
Author

@tiaanl thanks! @emilio when you get a chance?

@svgeesus
Copy link
Author

svgeesus commented Oct 4, 2023

Tests are all merged now, thanks to the reviewers.

Will this positive position be reflected on https://mozilla.github.io/standards-positions/ at some point?

@martinthomson
Copy link
Member

Lots of noise here, I missed the two positive statements up-thread (and I suspect others did too). I'll defer to them as to whether this appears on a dashboard.

@emilio, @tiaanl, if you think that this needs a dashboard entry, can I request that you create a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants