Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add netinfo API (harmful) #316

Merged
merged 3 commits into from
Apr 15, 2020
Merged

Add netinfo API (harmful) #316

merged 3 commits into from
Apr 15, 2020

Conversation

martinthomson
Copy link
Member

Closes #117.

marcoscaceres
marcoscaceres reviewed Apr 15, 2020
View reviewed changes
activities.json Outdated
"ciuName": "netinfo",
"description": "The Network Information API enables web applications to access information about the network connection in use by the device.",
"id": "netinfo",
"mozBugUrl": null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe https://bugzilla.mozilla.org/show_bug.cgi?id=1057169 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could "won't fix" that also.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the link. We probably should, but that's a separate decision.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't resist.

@annevk annevk merged commit a4e24f2 into mozilla:master Apr 15, 2020
@martinthomson martinthomson deleted the netinfo branch April 15, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres left review comments

@annevk annevk annevk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Network Information API
3 participants
@martinthomson @marcoscaceres @annevk