Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Scroll-driven animations (positive) #978

Merged
merged 2 commits into from Feb 1, 2024
Merged

Add Scroll-driven animations (positive) #978

merged 2 commits into from Feb 1, 2024

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Jan 30, 2024

Closes #347

@zcorpan
Copy link
Member Author

zcorpan commented Jan 30, 2024

Also see Fyrd/caniuse#6956 for caniuse.

tantek
tantek requested changes Jan 31, 2024
View reviewed changes
Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This position reflects our evaluation per the issue.

One minor nit in the description, it should mention CSS properties first (which are in the draft), and drop "markup". I.e.:

s/Defines an API and markup for/Defines CSS properties and an API for

@zcorpan zcorpan mentioned this pull request Jan 31, 2024
Merged
zcorpan
zcorpan commented Jan 31, 2024
View reviewed changes
activities.json Outdated Show resolved Hide resolved
@zcorpan
Copy link
Member Author

zcorpan commented Jan 31, 2024

@tantek fixed, and suggested that change to the spec.

tantek
tantek approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and nicely done with the upstream spec fix as well!

@tantek tantek merged commit 275f92c into main Feb 1, 2024
1 check passed
@tantek tantek deleted the zcorpan/scroll-driven-animations branch February 1, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tantek tantek tantek approved these changes

@martinthomson martinthomson martinthomson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scroll-driven Animations
3 participants
@zcorpan @tantek @martinthomson