Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

:has() selector (Positive) #986

Merged
merged 4 commits into from Feb 20, 2024
Merged

:has() selector (Positive) #986

merged 4 commits into from Feb 20, 2024

Conversation

dshin-moz
Copy link
Contributor

@dshin-moz dshin-moz commented Feb 15, 2024 •
edited by zcorpan

Closes #528

zcorpan
zcorpan requested changes Feb 15, 2024
View reviewed changes
activities.json Outdated Show resolved Hide resolved
activities.json Outdated Show resolved Hide resolved
@dshin-moz @zcorpan
Update activities.json
eef4d04 
Co-authored-by: Simon Pieters <zcorpan@gmail.com>
tantek
tantek approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified this works

tantek
tantek approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the patch updates here.

tantek
tantek approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @martinthomson's suggested change.

@dshin-moz @martinthomson
Update activities.json
f5163d4 
Co-authored-by: Martin Thomson <mt@lowentropy.net>
@zcorpan zcorpan merged commit 7166458 into mozilla:main Feb 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinthomson martinthomson martinthomson left review comments

@tantek tantek tantek approved these changes

@zcorpan zcorpan zcorpan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

:has() pseudo class
4 participants
@dshin-moz @tantek @martinthomson @zcorpan