New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can now specify command line parameters in any order. #16

Merged

nukeador merged 1 commit into mozilla:master from soccerjustinh1:issue/15/Command-line-input-parameters-incorrect

May 20, 2019

Contributor

soccerjustinh1 commented May 18, 2019

While I was making some changes for the command line parameters I have made some additional changes as a suggestion to this pull request.

To parse the input settings file as its own python file,
Updated the test-case suite to follow the DRY (Don't Repeat Yourself) principle,
Allow the user to specify a settings file on the command line so there is an optional --settings switch
Updated the README.md documentation to run in lock-step with the code implementation.

The regression suite is passing all 26 test-cases.


          Can now specify command line parameters in any order with updated usa…

866075a

…ge. Testcases are following DRY principle; fixes mozilla#15.

nukeador commented May 20, 2019

Thanks for this!

nukeador merged commit 3893648 into mozilla:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment