Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Log in/ Sign up button label is displayed incorrectly. #13

Closed
ovidiuboca1 opened this issue Dec 12, 2019 · 5 comments
Closed

The Log in/ Sign up button label is displayed incorrectly. #13

ovidiuboca1 opened this issue Dec 12, 2019 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@ovidiuboca1
Copy link

STR:

Prerequisites: You don't need to be logged in.

  1. Go to Mozilla Support page
  2. Resize the browser window, shrink it.

ER: The Log in/ Sign up button label is displayed correctly.
AR: The Log in/ Sign up button label is displayed incorrectly.
Screenshot 2019-12-12 at 17 36 59

@ovidiuboca1 ovidiuboca1 changed the title The Log in/ Sign up button label is displayed wrong The Log in/ Sign up button label is displayed incorrectly. Dec 12, 2019
@akatsoulas akatsoulas transferred this issue from mozilla/kitsune Dec 20, 2019
@akatsoulas akatsoulas added the bug Something isn't working label Dec 20, 2019
@akatsoulas akatsoulas added this to the Responsive redesign milestone Dec 20, 2019
@akatsoulas akatsoulas added this to Current Sprint in SUMO Engineering Board Dec 20, 2019
@viorelaioia-zz viorelaioia-zz moved this from Current Sprint to Backlog in SUMO Engineering Board Dec 30, 2019
@viorelaioia-zz viorelaioia-zz moved this from Backlog to Current Sprint in SUMO Engineering Board Dec 30, 2019
@ovidiuboca1
Copy link
Author

Retested and now the "Log in/ Sign up" button is replaced with a different icon (https://imgur.com/a/RWS61j6). The new icon is not actionable.

@jess-cook03
Copy link

@kkellydesign in addition to this ^ the copy globally for those buttons should change to 'Sign In/Up' as updated in the latest navigation here

kkellydesign added a commit to lincolnloop/kitsune that referenced this issue Jan 17, 2020
kkellydesign added a commit to lincolnloop/kitsune that referenced this issue Jan 17, 2020
@kkellydesign
Copy link

kkellydesign commented Jan 17, 2020

We've run out of room for all of the buttons and the search bar as the user scrolls down the page, so I just removed the buttons on scroll. Let me know if this is an acceptable fix to this problem. This will be available on the test server when mozilla/kitsune#4130 goes up.

New button text:
Screen Shot 2020-01-17 at 1 53 52 PM

on scroll at tablet size:
Screen Shot 2020-01-17 at 1 54 00 PM

@kkellydesign kkellydesign self-assigned this Jan 17, 2020
@kkellydesign kkellydesign moved this from Current Sprint to QA in SUMO Engineering Board Jan 17, 2020
@jess-cook03
Copy link

@kkellydesign new button looks great
-- as for the scroll on navigation as you go down the page ... I think that is fine for now, removing them, as long as they stay persistent in the nav above.

@ovidiuboca1
Copy link
Author

Verified on the staging site and the label button and the scroll behavior are fixed.

@akatsoulas akatsoulas moved this from Done to Ready to deploy in SUMO Engineering Board Feb 12, 2020
SUMO Engineering Board automation moved this from Ready to deploy to Done Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

4 participants