Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "Results" section from the page footer is displayed in different way from the mockups [Search pages] #130

Closed
ovidiuboca1 opened this issue Jan 27, 2020 · 3 comments
Closed

The "Results" section from the page footer is displayed in different way from the mockups [Search pages] #130

ovidiuboca1 opened this issue Jan 27, 2020 · 3 comments
Labels
bug Something isn't working
Projects
SUMO Engineering Board
Milestone
Responsive redesign

Comments

@ovidiuboca1
Copy link

STR:

  1. Go to https://test.sumo.mozit.cloud/en-US/
  2. Perform a search after a word, ex. firefox
  3. Scroll to the bottom of the page

ER: The Results section is displayed like in the mockups - https://app.zeplin.io/project/5db3524d3cd0612c5d2f78a9/screen/5e189569853c8c01a6248a73
AR: The results section is displayed like in this print-screen
Screenshot 2020-01-27 at 15 07 30
@ovidiuboca1 ovidiuboca1 added the bug Something isn't working label Jan 27, 2020
@ovidiuboca1 ovidiuboca1 added this to Triage in SUMO Engineering Board via automation Jan 27, 2020
@ovidiuboca1 ovidiuboca1 added this to the Responsive redesign milestone Jan 27, 2020
@ovidiuboca1 ovidiuboca1 changed the title The "Results" section from the page footer is displayed in different way from the mockups The "Results" section from the page footer is displayed in different way from the mockups [Search pages] Jan 27, 2020
@ovidiuboca1 ovidiuboca1 mentioned this issue Jan 27, 2020
Closed
kkellydesign added a commit to lincolnloop/kitsune that referenced this issue Jan 27, 2020
@kkellydesign
pagination component added, ref mozilla/sumo#130
8c5f5c2
@kkellydesign
Copy link

kkellydesign commented Jan 27, 2020 •
edited
Loading

These changes will be in when this PR is deployed: mozilla/kitsune#4150

Please note though that my local database doesn't have enough articles to trigger the pagination, so I sort of built this blind. I built it in the styleguide and ported the code to the correct spot. If this misses the mark, please reassign to me.

Here's what it looks like in the styleguide:

Screen Shot 2020-01-27 at 12 20 01 PM

Screen Shot 2020-01-27 at 12 20 07 PM

@kkellydesign kkellydesign moved this from Triage to QA in SUMO Engineering Board Jan 27, 2020
kkellydesign added a commit to lincolnloop/kitsune that referenced this issue Jan 27, 2020
@kkellydesign
pagination component fixes. ref mozilla/sumo#130
4d7ac75
akatsoulas pushed a commit to akatsoulas/kitsune that referenced this issue Jan 31, 2020
@kkellydesign @akatsoulas
Add pagination component added.
a9d70f1 
*ref mozilla/sumo#130
@kkellydesign
Copy link

One minor fix will be in for this, where on the test server, it says "results untitled of 305." Other than that, this is ready for QA. I'll hold off on marking this as ready for now.

mozilla/kitsune#4170

@ovidiuboca1 ovidiuboca1 moved this from QA to Ready to deploy in SUMO Engineering Board Feb 27, 2020
@ovidiuboca1
Copy link
Author

This issue was tested and I can confirm the fix.

akatsoulas pushed a commit to akatsoulas/kitsune that referenced this issue Mar 12, 2020
@kkellydesign @akatsoulas
Add pagination component added.
54c89b1 
*ref mozilla/sumo#130
SUMO Engineering Board automation moved this from Ready to deploy to Done Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
SUMO Engineering Board
  
Done
Milestone
Responsive redesign
Development

No branches or pull requests
3 participants
@kkellydesign @akatsoulas @ovidiuboca1