Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive Redesign // Subproduct Pages #30

Closed
jess-cook03 opened this issue Dec 5, 2019 · 7 comments
Closed

Responsive Redesign // Subproduct Pages #30

jess-cook03 opened this issue Dec 5, 2019 · 7 comments
Assignees

Comments

@jess-cook03
Copy link

No description provided.

@jess-cook03 jess-cook03 self-assigned this Dec 5, 2019
@jess-cook03
Copy link
Author

@kkellydesign @madasan @akatsoulas @flekkowich
Subproduct pages link to designs in Zeplin
To be reviewed in today's designs review meeting.

@kkellydesign
Copy link

kkellydesign commented Dec 13, 2019

@madasan This is in: mozilla/kitsune#4085
Here's a local link: http://127.0.0.1:8000/en-US/products/firefox

I have one question on this one. In non-firefox browsers, we have this:

Screen Shot 2019-12-13 at 8 53 32 AM

On the current site, this is what it looks like:
Screen Shot 2019-12-13 at 8 55 57 AM

Do we still need that? If so, should I just use the blue filled-in button and recreate the layout from the old site?

@madasan
Copy link

madasan commented Dec 13, 2019

Yes, we need to keep the download button

@kkellydesign
Copy link

This is in:
Screen Shot 2019-12-20 at 7 29 32 AM

@akatsoulas akatsoulas transferred this issue from mozilla/kitsune Dec 23, 2019
@akatsoulas akatsoulas added this to the Responsive redesign milestone Dec 23, 2019
@kkellydesign
Copy link

https://test.sumo.mozit.cloud/en-US/products/firefox

This is ready for QA, with some exceptions. Static files are still not loading, which means:

  • Fonts are using the sans-serif fallback instead of Inter and Metropolis.
  • The masthead photo is displaying the alt tag for the broken image instead of the logo. Here's what that looks like for me locally, where the fallback image is working correctly. To be clear, that's what happens when there's an empty field in the database, not a broken link. When the staticfiles works, it should populate the actual firefox logo in this spot.

Screen Shot 2020-01-24 at 3 02 07 PM

* Icons under 'frequent topics' and 'featured articles' are both missing. * The close button on notifications is missing.

Additional notes:
In an upcoming PR, the search on this page will work identically to the homepage. It's functional now, but the layout is a bit off. The icons on search results are also related to the staticfiles issue.

@ovidiuboca1
Copy link

Comparing the dev environment and the staging one related to the sub-products pages I see different behavior. On https://test.sumo.mozit.cloud/en-US/ I don't see any sub-product pages. I did a screen recording where I compared the dev environment, where the sub-product pages exist and the test environment where I don't see any sub-product pages: https://streamable.com/nhoqt

@kkellydesign
Copy link

I believe this is either an issue with data differences, or subproducts not being implemented yet in the responsive-redesign branch. @akatsoulas, can you confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants