This repository has been archived by the owner on Dec 1, 2017. It is now read-only.
Extend media.js to be able to handle all times of video/audio/data communications #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd add unit tests
| var chan = pc.createDataChannel("Talkilla"); | ||
|
|
||
| pc.ondatachannel = function(aEvent) { | ||
| app.trigger("add_data_channel", chan, aEvent.chan); |
There was a problem hiding this comment.
I think you wanted to write aEvent.channel here (here is the code sending this event: http://hg.mozilla.org/mozilla-central/annotate/c190422547ed/dom/media/PeerConnection.js#l1027)
|
Closing PR as we have decided to move forward with a backbone based model that provides a better wrapper around the media tools. We may still base some of the unit tests for that model on the ideas provided in this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is initial work for supporting audio and data only communications as well as other combinations.
It extends the interfaces to media.js to add possibilities for selection of different types of calls, and adds unit testing for all the interfaces.