This repository has been archived by the owner on Dec 1, 2017. It is now read-only.
Complete the hook up of offer creation and sending when opening the chat window #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, and set the video and audio attributes on the webrtc model before starting the call.
… to have the call type set before being called.
| @@ -30,10 +33,10 @@ describe("ChatApp", function() { | |||
| sandbox.stub(ChatApp.prototype, handler); | |||
| chatApp = new ChatApp(); | |||
|
|
|||
| chatApp.port.trigger(event, caller, callee); | |||
| chatApp.port.trigger(event, outgoingData); | |||
There was a problem hiding this comment.
I guess outgoingData should be incomingData here as triggering this event simulate data coming from the worker and going into the application.
|
r=@tOkeshu good to merge |
tOkeshu
added a commit
that referenced
this pull request
May 31, 2013
Complete the hook up of offer creation and sending when opening the chat window
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets us to the stage where opening a chat window will correctly send a message to the server for the call offer. Generally the issues were function parameters not matching what they were being called with.