Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using approxCountDistinct to reduce processing time #276

Merged
merged 1 commit into from
Aug 2, 2017

Conversation

sunahsuh
Copy link
Contributor

@sunahsuh sunahsuh commented Aug 2, 2017

The experiment aggregates job is still timing out, so I think it's worth at least giving this a try

@sunahsuh sunahsuh requested a review from fbertsch August 2, 2017 21:12
Copy link
Contributor

@fbertsch fbertsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. This is a real mystery. My guess is this won't fix it :/

@sunahsuh sunahsuh merged commit 07a5a67 into mozilla:master Aug 2, 2017
@sunahsuh sunahsuh deleted the use-approx-distinct branch August 2, 2017 21:40
@codecov-io
Copy link

Codecov Report

Merging #276 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #276   +/-   ##
=======================================
  Coverage   66.11%   66.11%           
=======================================
  Files          37       37           
  Lines        3373     3373           
  Branches       83       83           
=======================================
  Hits         2230     2230           
  Misses       1143     1143
Impacted Files Coverage Δ
...try/experiments/analyzers/ExperimentAnalyzer.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 783ea94...873e257. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants