Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't sanitize or trim for small data counts #258

Open
fbertsch opened this issue Nov 4, 2016 · 4 comments
Open

Don't sanitize or trim for small data counts #258

fbertsch opened this issue Nov 4, 2016 · 4 comments

Comments

@fbertsch
Copy link
Contributor

fbertsch commented Nov 4, 2016

When there's no data when sanitizing and ignoring buckets with low numbers of values, it should automatically turn those off and give you the little data it does have, and print a warning, instead of just saying "nothing here"

@mreid-moz
Copy link
Contributor

Including a warning that there are few data points and that conclusions should be drawn carefully, if at all, would be good.

@ecomerford
Copy link
Contributor

Does this issue still need to be resolved? I'f so, I'm happy to work on it!

I'd appreciate any tips on where to start. Thank you!

@chutten
Copy link
Contributor

chutten commented Feb 27, 2018

This issue does still need to be resolved, but it isn't really a good place to get started in the repository.

If you'd like to press on anyway, if you look at a probe with a very small number of samples (like say, this one) it shows no data. Item 2 on the suggestions says to turn off "sanitize data" and maybe that would help. The idea would be to automatically turn off "sanitize data", open the advanced settings, display a notice, and show the (very little) data in the cases when sanitizing removes all data that would be displayed.

So it's kinda large for a first go. Instead may I recommend #400? It ought to be a better introduction to the codebase, and then you can swing back around to this one later.

@ecomerford
Copy link
Contributor

Got it, thanks! It looks as though someone else is interested in #400, but I'll keep looking around if you think this is going to be too involved.

@wlach wlach removed the mentored label Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants