Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Backfill frontend tests for new React system #1399

Closed
lmorchard opened this issue Sep 21, 2016 · 1 comment
Closed

Backfill frontend tests for new React system #1399

lmorchard opened this issue Sep 21, 2016 · 1 comment
Assignees
@lmorchard
Projects
Project Zero - Code Quality
Milestone
TXP-37 React Next...

Comments

@lmorchard
Copy link
Contributor

In #1351, we added a new system for frontend unit tests with React. That PR only came with 2 tests. We should backfill the rest.
@johngruen johngruen added this to the TXP-37 React Next Steps milestone Sep 26, 2016
@lmorchard lmorchard self-assigned this Sep 26, 2016
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 28, 2016
@lmorchard
Issue mozilla#1399: Add test for DiscussDialog
dd26612
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 29, 2016
@lmorchard
Issue mozilla#1399: Backfill some more simple tests
954192b
@lmorchard lmorchard mentioned this issue Sep 29, 2016
Closed
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 29, 2016
@lmorchard
Issue mozilla#1399: Backfill some more simple tests
22148d2
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 29, 2016
@lmorchard
Issue mozilla#1399: Add EmailDialog test
aba06a4
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 29, 2016
@lmorchard
Issue mozilla#1399: Add EmailDialog test
08c81e4
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 29, 2016
@lmorchard
Backfill some component tests
19c5755 
Issue mozilla#1399
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 29, 2016
@lmorchard
Backfill some component tests
f78fbf3 
Issue mozilla#1399
@lmorchard lmorchard mentioned this issue Sep 29, 2016
Merged
5 tasks
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 30, 2016
@lmorchard
Backfill some component tests
907875e 
Issue mozilla#1399
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 30, 2016
@lmorchard
Backfill some component tests
df80cb7 
Issue mozilla#1399
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 30, 2016
@lmorchard
Backfill some component tests
a63ad5a 
Issue mozilla#1399
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 30, 2016
@lmorchard
Backfill some component tests
87fbf14 
Issue mozilla#1399
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 30, 2016
@lmorchard
Backfill some component tests
8428659 
Issue mozilla#1399
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 4, 2016
@lmorchard
Backfill some component tests
8c4af75 
Issue mozilla#1399
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 4, 2016
@lmorchard
Backfill some component tests
3397002 
Issue mozilla#1399
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 4, 2016
@lmorchard
Backfill some component tests
21814e6 
Issue mozilla#1399
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 5, 2016
@lmorchard
Backfill some component tests
d4bba90 
Issue mozilla#1399
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 5, 2016
@lmorchard
Backfill component tests
cb72142 
- Adding tests for components

- Updated test runner command to use frontend/test-setup.js

- New dependencies: jsdom, sinon

Issue mozilla#1399
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 6, 2016
@lmorchard
Backfill test for RetirePage component
b346248 
- Move hack to set window.navigator.testpilotAddon on fake uninstall
  into a helper injected from App

- Move FAKE_UNINSTALL_DELAY to props.fakeUninstallDelay in RetirePage

- Add prop types & default props to RetirePage

- Tests

Issue mozilla#1399
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 6, 2016
@lmorchard
Backfill tests for SharePage component
a8f3c2f 
- Add prop types to SharePage

- Tests

Issue mozilla#1399
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 6, 2016
@lmorchard
Backfill tests for Restart page
6d26cbe 
- Add propTypes to Restart component

- Tests

Issue mozilla#1399
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 6, 2016
@lmorchard
Backfill tests for RetireConfirmationDialog
e64158e 
- Move uninstallAddon to helper injected by App container

- Add propTypes to RetireConfirmationDialog

- Tests

Issue mozilla#1399
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 6, 2016
@lmorchard
Backfill tests for RetireConfirmationDialog
5eba1a1 
- Move uninstallAddon to helper injected by App container

- Add propTypes to RetireConfirmationDialog

- Tests

Issue mozilla#1399
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 6, 2016
@lmorchard
Backfill tests for LandingPage
b288a01 
Issue mozilla#1399
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 6, 2016
@lmorchard
Backfill component tests
61702d4 
- Adding tests for components

- Updated test runner command to use frontend/test-setup.js

- New dependencies: jsdom, sinon

Issue mozilla#1399
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 6, 2016
@lmorchard
Backfill test for RetirePage component
3867dc4 
- Move hack to set window.navigator.testpilotAddon on fake uninstall
  into a helper injected from App

- Move FAKE_UNINSTALL_DELAY to props.fakeUninstallDelay in RetirePage

- Add prop types & default props to RetirePage

- Tests

Issue mozilla#1399
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 6, 2016
@lmorchard
Backfill tests for SharePage component
8c137b4 
- Add prop types to SharePage

- Tests

Issue mozilla#1399
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 6, 2016
@lmorchard
Backfill tests for Restart page
c96efee 
- Add propTypes to Restart component

- Tests

Issue mozilla#1399
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 6, 2016
@lmorchard
Backfill tests for RetireConfirmationDialog
bc1de92 
- Move uninstallAddon to helper injected by App container

- Add propTypes to RetireConfirmationDialog

- Tests

Issue mozilla#1399
lmorchard added a commit to lmorchard/testpilot that referenced this issue Oct 6, 2016
@lmorchard
Backfill tests for LandingPage
b6b08dc 
Issue mozilla#1399
@lmorchard
Copy link
Contributor Author

Going to say this is closed by #1488 - though there are still 3 components that need tests, as well as reducers & actions that could use some tests. I'll file separate issues for the remaining components

This was referenced Oct 6, 2016
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lmorchard lmorchard

Labels
None yet
Projects
No open projects
Project Zero - Code Quality
Done
Milestone
TXP-37 React Next Steps
Development

No branches or pull requests
3 participants
@lmorchard @johngruen @ckprice