addon installed state races on home page

[dannycoates]

I managed to trigger two unfortunate races setting the installed state of the addon that caused the experiment list page to show the no-addon version instead of the (correct) with-addon version. Once the page was in the no-addon state it stayed there.

I added a few console.warn lines before each dispatch of setHasAddon. Here's the log from a time when the page goes from the loading view to no-addon view.

And here's a particularly weird one where the page goes from loading flashing to with-addon but then quickly to no-addon.

[dannycoates]

Happens in prod too, so it wasn't added this week

[dannycoates]

This is PageMod being a jerk. The short of it is that the detach event from a previous page load can trigger on the current page and trick the frontend into thinking the addon is gone.

It doesn't look like a "normal" page refresh is problematic so far, but when you navigate by changing the url (or not) in the address bar and hitting enter there's a chance you'll get this behavior.

[SoftVision-PaulOiegas]

Isn't this the same issue from #1574 ?

[dannycoates]

Isn't this the same issue from #1574 ?

Indeed it is!