This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
investigate l20n/react integration #1714
Comments
|
Sorry about the trouble l20n has been causing. It was designed to work seamlessly with regular DOM. Turns out that this isn't well aligned with how React works. I wrote a prototype of a library which uses L20n's low-level API and file format, and integrates tightly into React. I wrote about here: https://groups.google.com/forum/#!topic/mozilla.tools.l10n/eP-Vo9UQz6o @dannycoates, @chuckharmston, @6a68, @lmorchard -- I'd love to hear your thoughts on this. Feel free to reply in the newsgroup or ping my on IRC. Thanks! |
ghost
added
the
|
I think we're ready to move to fluent-react next sprint. @stasm it looks really good, thank you so much. I'll file bugs against the repo there if I encounter any. |
|
Hey, @fzzzy, I'm very happy to hear this! What is the timeline of the next sprint? I'm currently working on a few improvements to fluent-react related to falling back on other languages when translations are missing. I plan to finish by the end of next week. When Test Pilot moves to fluent-react we will also need to migrate the existing translations to the updated FTL syntax. (Fluent uses a newer version of the syntax than L20n.js does.) The changes are minimal (https://github.com/mathjazz/testpilot/pull/1/files is an example in a test repo) and we already have a plan for how to use Pontoon to automate them. Our plan was to target the dev cycle of April 25—May 9. Would that work for you? |
|
@stasm I'll start working on it, but I won't plan on it being landed in production until you are ready. April 25-May 9 timeframe is fine. Thanks! |
|
@fzzzy I've published |
|
I need to remove our use of dangerouslySetInnerHTML before I can switch over. I think I can use https://www.npmjs.com/package/html-react-parser instead. If anyone has a recommendation for another html to react parser, let me know. |
fzzzy
added a commit
to fzzzy/testpilot
that referenced
this issue
Jul 13, 2017
…tter react integration. Squashed commit of the following: commit ef5340c Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jul 12 16:03:42 2017 -0400 Add fluent-react to flow-typed commit 7c78998 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jul 12 14:42:59 2017 -0400 Use fluent-langneg commit 5ae67cf Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jul 12 14:41:40 2017 -0400 Fix lint commit 68cd0bf Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jul 12 11:59:31 2017 -0400 Implement LocalizedHtml component and use it to parse the strings on the ExperimentPage that contain html commit 04469f4 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jul 12 10:41:31 2017 -0400 Use fluent-react/compat so we don't include the un-babelified version in vendor.js commit 22fa6be Merge: f6f9989 e4a0efa Author: Donovan Preston <dpreston@mozilla.com> Date: Fri Jun 30 13:31:47 2017 -0400 Merge pull request #4 from stasm/fluent-react-tests WIP Fix test failures caused by fluent-react commit e4a0efa Author: Staś Małolepszy <stas@mozilla.com> Date: Thu Jun 29 19:52:37 2017 +0200 WIP Fix test failures caused by fluent-react fluent-react 0.4.1 relaxes the restriction about Localized components being only valid inside of LocalizationProvider. The tests now pass but React reports the following warning: Warning: Failed context type: The l10n context field must be an instance of ReactLocalization. in Localized (created by NewsletterForm) in label (created by NewsletterForm) in form (created by NewsletterForm) in NewsletterForm (created by Unknown) in Unknown The warning could be silenced by temporarily muting console.warn, or by implementing a wrapper around Enzyme's mount which provides a fake ReactLocalization in the context. Here's what the wrapper could look like: https://github.com/stasm/fluent.js/blob/fluent-enzyme/fluent-enzyme/src/index.js#L35-L49 I also factored the findLocalizedById function out of tests and into the util.js module. There are 7 skipped tests. I wasn't sure what their result HTML should be. commit f6f9989 Author: Donovan Preston <donovanpreston@gmail.com> Date: Thu Jun 29 18:23:33 2017 -0400 Remove embedded html from the rest of app.ftl strings commit 9bcf925 Author: Donovan Preston <donovanpreston@gmail.com> Date: Thu Jun 29 17:29:53 2017 -0400 Remove some of the html embedded in strings. commit ca044ff Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 17:39:57 2017 -0400 Remove weird double nested span. commit 796af3b Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 15:49:19 2017 -0400 Use … commit 2e38e0d Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 15:48:29 2017 -0400 Remove empty className commit 6fa3622 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 15:40:42 2017 -0400 Rename commit 96a5531 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 11:47:29 2017 -0400 Annotate the correct return type commit 7640080 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 11:45:27 2017 -0400 Quote apostrophe commit e141182 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 11:39:25 2017 -0400 Fix the type of titleL10nArgs commit 6d98fad Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 11:38:58 2017 -0400 Remove copy-pasted junk commit 40354f7 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 11:30:07 2017 -0400 Don't try to JSON.parse undefined commit f6f648f Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 10:23:27 2017 -0400 Remove trailing whitespace commit 6f88564 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 10:22:21 2017 -0400 Move the key attributes to the right element. commit 8bd2383 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 10:19:10 2017 -0400 Fix typos. commit 36947d0 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 10:18:28 2017 -0400 Convert Warning to fluent-react commit c62f623 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 10:07:55 2017 -0400 Convert UpdateList to fluent-react. commit 9b9eed3 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 10:05:23 2017 -0400 Convert Settings to fluent-react. commit b321c1f Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:56:08 2017 -0400 Convert RetireConfirmationDialog to fluent-react. commit 6b74e10 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:53:45 2017 -0400 Convert PastExperiments to fluent-react. commit 57553c5 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:47:58 2017 -0400 Convert NewsletterForm to fluent-react. commit 7d313f5 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:43:21 2017 -0400 Convert NewsletterFooter to fluent-react. commit 30e2fb9 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:40:53 2017 -0400 Convert MainInstallButton to fluent-react commit 9871e90 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:25:59 2017 -0400 Convert Header to fluent-react commit 8521f28 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:25:06 2017 -0400 Convert Footer to fluent-react commit ecbff0d Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:15:50 2017 -0400 Convert ExperimentTourDialog to fluent-react commit 3863066 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:11:55 2017 -0400 Convert ExperimentRowCard to fluent-react. commit eb2931b Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:04:46 2017 -0400 Convert ExperimentPreFeedbackDialog to fluent-react. commit f3ccd94 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:02:19 2017 -0400 Convert ExperimentEolDialog to fluent-react commit 9fc0451 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:59:48 2017 -0400 Convert ExperimentDisableDialog to fluent-react commit e7ed44e Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:57:42 2017 -0400 Convert EmailDialog to fluent-react. commit b19989d Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:46:29 2017 -0400 Convert SharePage to fluent-react. commit aeb5e33 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:43:52 2017 -0400 Convert RetirePage to fluent-react. commit 55f8975 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:40:42 2017 -0400 Convert RestartPage to fluent-react. commit 6af6a16 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:38:35 2017 -0400 Convert OnboardingPage to fluent-react. commit cbd9b26 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:37:28 2017 -0400 Convert NotFoundPage to fluent-react commit 97cb105 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:35:09 2017 -0400 Convert HomePageWithAddon to fluent-react commit 0627c32 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:27:32 2017 -0400 Convert HomePageNoAddon to fluent-react commit ff13e4e Author: Donovan Preston <donovanpreston@gmail.com> Date: Tue Jun 27 11:44:30 2017 -0400 Convert ExperimentPage to fluent-react commit 425aea6 Author: Donovan Preston <donovanpreston@gmail.com> Date: Tue Jun 27 10:49:04 2017 -0400 Switch ErrorPage to fluent-react commit a6f7420 Author: Donovan Preston <donovanpreston@gmail.com> Date: Tue Jun 27 10:39:11 2017 -0400 Switch View over to fluent-react commit 9491234 Author: Donovan Preston <donovanpreston@gmail.com> Date: Tue Jun 27 10:38:59 2017 -0400 Remove console.log commit ecc5573 Author: Donovan Preston <donovanpreston@gmail.com> Date: Mon Jun 26 21:05:05 2017 -0400 Step 1 get it working commit 4aeafe5 Merge: aabd228 a4b561d Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 21 09:59:10 2017 -0400 Merge remote-tracking branch 'mozilla/master' commit aabd228 Merge: a697c28 9c85f55 Author: Donovan Preston <donovanpreston@gmail.com> Date: Tue Jun 20 11:37:05 2017 -0400 Merge branch 'master' of https://github.com/mozilla/testpilot commit a697c28 Merge: 32018a9 89a6d96 Author: Donovan Preston <donovanpreston@gmail.com> Date: Thu Jun 8 12:30:16 2017 -0400 Merge remote-tracking branch 'mozilla/master'
fzzzy
added a commit
to fzzzy/testpilot
that referenced
this issue
Jul 13, 2017
…tter react integration. Squashed commit of the following: commit ef5340c Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jul 12 16:03:42 2017 -0400 Add fluent-react to flow-typed commit 7c78998 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jul 12 14:42:59 2017 -0400 Use fluent-langneg commit 5ae67cf Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jul 12 14:41:40 2017 -0400 Fix lint commit 68cd0bf Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jul 12 11:59:31 2017 -0400 Implement LocalizedHtml component and use it to parse the strings on the ExperimentPage that contain html commit 04469f4 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jul 12 10:41:31 2017 -0400 Use fluent-react/compat so we don't include the un-babelified version in vendor.js commit 22fa6be Merge: f6f9989 e4a0efa Author: Donovan Preston <dpreston@mozilla.com> Date: Fri Jun 30 13:31:47 2017 -0400 Merge pull request #4 from stasm/fluent-react-tests WIP Fix test failures caused by fluent-react commit e4a0efa Author: Staś Małolepszy <stas@mozilla.com> Date: Thu Jun 29 19:52:37 2017 +0200 WIP Fix test failures caused by fluent-react fluent-react 0.4.1 relaxes the restriction about Localized components being only valid inside of LocalizationProvider. The tests now pass but React reports the following warning: Warning: Failed context type: The l10n context field must be an instance of ReactLocalization. in Localized (created by NewsletterForm) in label (created by NewsletterForm) in form (created by NewsletterForm) in NewsletterForm (created by Unknown) in Unknown The warning could be silenced by temporarily muting console.warn, or by implementing a wrapper around Enzyme's mount which provides a fake ReactLocalization in the context. Here's what the wrapper could look like: https://github.com/stasm/fluent.js/blob/fluent-enzyme/fluent-enzyme/src/index.js#L35-L49 I also factored the findLocalizedById function out of tests and into the util.js module. There are 7 skipped tests. I wasn't sure what their result HTML should be. commit f6f9989 Author: Donovan Preston <donovanpreston@gmail.com> Date: Thu Jun 29 18:23:33 2017 -0400 Remove embedded html from the rest of app.ftl strings commit 9bcf925 Author: Donovan Preston <donovanpreston@gmail.com> Date: Thu Jun 29 17:29:53 2017 -0400 Remove some of the html embedded in strings. commit ca044ff Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 17:39:57 2017 -0400 Remove weird double nested span. commit 796af3b Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 15:49:19 2017 -0400 Use … commit 2e38e0d Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 15:48:29 2017 -0400 Remove empty className commit 6fa3622 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 15:40:42 2017 -0400 Rename commit 96a5531 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 11:47:29 2017 -0400 Annotate the correct return type commit 7640080 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 11:45:27 2017 -0400 Quote apostrophe commit e141182 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 11:39:25 2017 -0400 Fix the type of titleL10nArgs commit 6d98fad Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 11:38:58 2017 -0400 Remove copy-pasted junk commit 40354f7 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 11:30:07 2017 -0400 Don't try to JSON.parse undefined commit f6f648f Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 10:23:27 2017 -0400 Remove trailing whitespace commit 6f88564 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 10:22:21 2017 -0400 Move the key attributes to the right element. commit 8bd2383 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 10:19:10 2017 -0400 Fix typos. commit 36947d0 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 10:18:28 2017 -0400 Convert Warning to fluent-react commit c62f623 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 10:07:55 2017 -0400 Convert UpdateList to fluent-react. commit 9b9eed3 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 10:05:23 2017 -0400 Convert Settings to fluent-react. commit b321c1f Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:56:08 2017 -0400 Convert RetireConfirmationDialog to fluent-react. commit 6b74e10 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:53:45 2017 -0400 Convert PastExperiments to fluent-react. commit 57553c5 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:47:58 2017 -0400 Convert NewsletterForm to fluent-react. commit 7d313f5 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:43:21 2017 -0400 Convert NewsletterFooter to fluent-react. commit 30e2fb9 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:40:53 2017 -0400 Convert MainInstallButton to fluent-react commit 9871e90 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:25:59 2017 -0400 Convert Header to fluent-react commit 8521f28 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:25:06 2017 -0400 Convert Footer to fluent-react commit ecbff0d Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:15:50 2017 -0400 Convert ExperimentTourDialog to fluent-react commit 3863066 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:11:55 2017 -0400 Convert ExperimentRowCard to fluent-react. commit eb2931b Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:04:46 2017 -0400 Convert ExperimentPreFeedbackDialog to fluent-react. commit f3ccd94 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:02:19 2017 -0400 Convert ExperimentEolDialog to fluent-react commit 9fc0451 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:59:48 2017 -0400 Convert ExperimentDisableDialog to fluent-react commit e7ed44e Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:57:42 2017 -0400 Convert EmailDialog to fluent-react. commit b19989d Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:46:29 2017 -0400 Convert SharePage to fluent-react. commit aeb5e33 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:43:52 2017 -0400 Convert RetirePage to fluent-react. commit 55f8975 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:40:42 2017 -0400 Convert RestartPage to fluent-react. commit 6af6a16 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:38:35 2017 -0400 Convert OnboardingPage to fluent-react. commit cbd9b26 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:37:28 2017 -0400 Convert NotFoundPage to fluent-react commit 97cb105 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:35:09 2017 -0400 Convert HomePageWithAddon to fluent-react commit 0627c32 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:27:32 2017 -0400 Convert HomePageNoAddon to fluent-react commit ff13e4e Author: Donovan Preston <donovanpreston@gmail.com> Date: Tue Jun 27 11:44:30 2017 -0400 Convert ExperimentPage to fluent-react commit 425aea6 Author: Donovan Preston <donovanpreston@gmail.com> Date: Tue Jun 27 10:49:04 2017 -0400 Switch ErrorPage to fluent-react commit a6f7420 Author: Donovan Preston <donovanpreston@gmail.com> Date: Tue Jun 27 10:39:11 2017 -0400 Switch View over to fluent-react commit 9491234 Author: Donovan Preston <donovanpreston@gmail.com> Date: Tue Jun 27 10:38:59 2017 -0400 Remove console.log commit ecc5573 Author: Donovan Preston <donovanpreston@gmail.com> Date: Mon Jun 26 21:05:05 2017 -0400 Step 1 get it working commit 4aeafe5 Merge: aabd228 a4b561d Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 21 09:59:10 2017 -0400 Merge remote-tracking branch 'mozilla/master' commit aabd228 Merge: a697c28 9c85f55 Author: Donovan Preston <donovanpreston@gmail.com> Date: Tue Jun 20 11:37:05 2017 -0400 Merge branch 'master' of https://github.com/mozilla/testpilot commit a697c28 Merge: 32018a9 89a6d96 Author: Donovan Preston <donovanpreston@gmail.com> Date: Thu Jun 8 12:30:16 2017 -0400 Merge remote-tracking branch 'mozilla/master'
fzzzy
added a commit
to fzzzy/testpilot
that referenced
this issue
Jul 13, 2017
…tter react integration. Squashed commit of the following: commit ef5340c Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jul 12 16:03:42 2017 -0400 Add fluent-react to flow-typed commit 7c78998 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jul 12 14:42:59 2017 -0400 Use fluent-langneg commit 5ae67cf Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jul 12 14:41:40 2017 -0400 Fix lint commit 68cd0bf Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jul 12 11:59:31 2017 -0400 Implement LocalizedHtml component and use it to parse the strings on the ExperimentPage that contain html commit 04469f4 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jul 12 10:41:31 2017 -0400 Use fluent-react/compat so we don't include the un-babelified version in vendor.js commit 22fa6be Merge: f6f9989 e4a0efa Author: Donovan Preston <dpreston@mozilla.com> Date: Fri Jun 30 13:31:47 2017 -0400 Merge pull request #4 from stasm/fluent-react-tests WIP Fix test failures caused by fluent-react commit e4a0efa Author: Staś Małolepszy <stas@mozilla.com> Date: Thu Jun 29 19:52:37 2017 +0200 WIP Fix test failures caused by fluent-react fluent-react 0.4.1 relaxes the restriction about Localized components being only valid inside of LocalizationProvider. The tests now pass but React reports the following warning: Warning: Failed context type: The l10n context field must be an instance of ReactLocalization. in Localized (created by NewsletterForm) in label (created by NewsletterForm) in form (created by NewsletterForm) in NewsletterForm (created by Unknown) in Unknown The warning could be silenced by temporarily muting console.warn, or by implementing a wrapper around Enzyme's mount which provides a fake ReactLocalization in the context. Here's what the wrapper could look like: https://github.com/stasm/fluent.js/blob/fluent-enzyme/fluent-enzyme/src/index.js#L35-L49 I also factored the findLocalizedById function out of tests and into the util.js module. There are 7 skipped tests. I wasn't sure what their result HTML should be. commit f6f9989 Author: Donovan Preston <donovanpreston@gmail.com> Date: Thu Jun 29 18:23:33 2017 -0400 Remove embedded html from the rest of app.ftl strings commit 9bcf925 Author: Donovan Preston <donovanpreston@gmail.com> Date: Thu Jun 29 17:29:53 2017 -0400 Remove some of the html embedded in strings. commit ca044ff Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 17:39:57 2017 -0400 Remove weird double nested span. commit 796af3b Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 15:49:19 2017 -0400 Use … commit 2e38e0d Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 15:48:29 2017 -0400 Remove empty className commit 6fa3622 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 15:40:42 2017 -0400 Rename commit 96a5531 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 11:47:29 2017 -0400 Annotate the correct return type commit 7640080 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 11:45:27 2017 -0400 Quote apostrophe commit e141182 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 11:39:25 2017 -0400 Fix the type of titleL10nArgs commit 6d98fad Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 11:38:58 2017 -0400 Remove copy-pasted junk commit 40354f7 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 11:30:07 2017 -0400 Don't try to JSON.parse undefined commit f6f648f Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 10:23:27 2017 -0400 Remove trailing whitespace commit 6f88564 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 10:22:21 2017 -0400 Move the key attributes to the right element. commit 8bd2383 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 10:19:10 2017 -0400 Fix typos. commit 36947d0 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 10:18:28 2017 -0400 Convert Warning to fluent-react commit c62f623 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 10:07:55 2017 -0400 Convert UpdateList to fluent-react. commit 9b9eed3 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 10:05:23 2017 -0400 Convert Settings to fluent-react. commit b321c1f Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:56:08 2017 -0400 Convert RetireConfirmationDialog to fluent-react. commit 6b74e10 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:53:45 2017 -0400 Convert PastExperiments to fluent-react. commit 57553c5 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:47:58 2017 -0400 Convert NewsletterForm to fluent-react. commit 7d313f5 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:43:21 2017 -0400 Convert NewsletterFooter to fluent-react. commit 30e2fb9 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:40:53 2017 -0400 Convert MainInstallButton to fluent-react commit 9871e90 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:25:59 2017 -0400 Convert Header to fluent-react commit 8521f28 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:25:06 2017 -0400 Convert Footer to fluent-react commit ecbff0d Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:15:50 2017 -0400 Convert ExperimentTourDialog to fluent-react commit 3863066 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:11:55 2017 -0400 Convert ExperimentRowCard to fluent-react. commit eb2931b Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:04:46 2017 -0400 Convert ExperimentPreFeedbackDialog to fluent-react. commit f3ccd94 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 09:02:19 2017 -0400 Convert ExperimentEolDialog to fluent-react commit 9fc0451 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:59:48 2017 -0400 Convert ExperimentDisableDialog to fluent-react commit e7ed44e Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:57:42 2017 -0400 Convert EmailDialog to fluent-react. commit b19989d Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:46:29 2017 -0400 Convert SharePage to fluent-react. commit aeb5e33 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:43:52 2017 -0400 Convert RetirePage to fluent-react. commit 55f8975 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:40:42 2017 -0400 Convert RestartPage to fluent-react. commit 6af6a16 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:38:35 2017 -0400 Convert OnboardingPage to fluent-react. commit cbd9b26 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:37:28 2017 -0400 Convert NotFoundPage to fluent-react commit 97cb105 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:35:09 2017 -0400 Convert HomePageWithAddon to fluent-react commit 0627c32 Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 28 08:27:32 2017 -0400 Convert HomePageNoAddon to fluent-react commit ff13e4e Author: Donovan Preston <donovanpreston@gmail.com> Date: Tue Jun 27 11:44:30 2017 -0400 Convert ExperimentPage to fluent-react commit 425aea6 Author: Donovan Preston <donovanpreston@gmail.com> Date: Tue Jun 27 10:49:04 2017 -0400 Switch ErrorPage to fluent-react commit a6f7420 Author: Donovan Preston <donovanpreston@gmail.com> Date: Tue Jun 27 10:39:11 2017 -0400 Switch View over to fluent-react commit 9491234 Author: Donovan Preston <donovanpreston@gmail.com> Date: Tue Jun 27 10:38:59 2017 -0400 Remove console.log commit ecc5573 Author: Donovan Preston <donovanpreston@gmail.com> Date: Mon Jun 26 21:05:05 2017 -0400 Step 1 get it working commit 4aeafe5 Merge: aabd228 a4b561d Author: Donovan Preston <donovanpreston@gmail.com> Date: Wed Jun 21 09:59:10 2017 -0400 Merge remote-tracking branch 'mozilla/master' commit aabd228 Merge: a697c28 9c85f55 Author: Donovan Preston <donovanpreston@gmail.com> Date: Tue Jun 20 11:37:05 2017 -0400 Merge branch 'master' of https://github.com/mozilla/testpilot commit a697c28 Merge: 32018a9 89a6d96 Author: Donovan Preston <donovanpreston@gmail.com> Date: Thu Jun 8 12:30:16 2017 -0400 Merge remote-tracking branch 'mozilla/master'
fzzzy
added a commit
that referenced
this issue
Aug 1, 2017
Fix #1714 Switch localization from l20n to fluent-react for better react integration.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In #1712 we fixed a conflict in how l20n and react both modify the dom which could easily happen again elsewhere. We ought to look into a more integrated approach.
This thread might have some leads: https://groups.google.com/forum/#!topic/mozilla.tools.l10n/XtxHgBEokCA
The text was updated successfully, but these errors were encountered: