Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Stop signing the main add-on in CircleCI #2651

Closed
lmorchard opened this issue Jul 24, 2017 · 1 comment
Closed

Stop signing the main add-on in CircleCI #2651

lmorchard opened this issue Jul 24, 2017 · 1 comment
Milestone
Sprint 29

Comments

@lmorchard
Copy link
Contributor

lmorchard commented Jul 24, 2017 •
edited

Related to #2643 & #2627 - we should stop signing the add-on via AMO in CircleCI runs on master branch.

This means that the add-on will no longer be installable from Dev & Stage environments via the big green button. The add-on would need to be installed in one of three ways:

  1. From the prod site, where it's a release version signed as a Mozilla Extension
  2. Via about:debugging as a temporary addon
  3. Using an unbranded Firefox build - which I think could still run through the usual UX on Dev & Stage, but I might be wrong about that after 57 stops supporting legacy add-ons
@lmorchard
Copy link
Contributor Author

An alternative might be to hard-code the add-on URL to production. Then, I think stage & dev will be able to install the current production add-on by way of the big green button on the site.

But, testing specific to unreleased versions of the add-on would need to be done via about:debugging. Which, hopefully, ends up not being too onerous because the main add-on shouldn't change very often.

@ghost ghost added the status: ready label Jul 24, 2017
@lmorchard lmorchard mentioned this issue Jul 27, 2017
Closed
lmorchard added a commit to lmorchard/testpilot that referenced this issue Aug 2, 2017
@lmorchard
Updates for new Mozilla Extension signing infrastructure
b7d0e75 
- Bump add-on version to 2.0.1
- Remove AMO-based signing from add-on build
- Change updateURL and updateLink in addon/package.json
- Stop attempting to sign the add-on on master branch CircleCI runs
- Exclude add-on from S3 upload in bin/deploy.sh
- Make addon URL path configurable across hosts for installation process
- Remove /static/addon/latest redirect in local dev server

Issue mozilla#2627.
Fixes mozilla#2651.
@lmorchard lmorchard mentioned this issue Aug 2, 2017
Merged
@ghost ghost modified the milestone: Sprint 29 Aug 7, 2017
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 18, 2017
@lmorchard
Upload unsigned packaged add-on to dev & stage
f69539f 
- For dev & stage only:
  - Restore the *.xpi and *.rdf upload removed in mozilla#2651
  - Restore creation of /static/addon/latest redirect with add-on hash
  - Configure frontend app to install add-on from /static/addon/latest

Issue mozilla#2865
@lmorchard lmorchard mentioned this issue Sep 18, 2017
Merged
lmorchard added a commit to lmorchard/testpilot that referenced this issue Sep 18, 2017
@lmorchard
Upload unsigned packaged add-on to dev & stage
203a10f 
- For dev & stage only:
  - Restore the *.xpi and *.rdf upload removed in mozilla#2651
  - Restore creation of /static/addon/latest redirect with add-on hash
  - Configure frontend app to install add-on from /static/addon/latest

Issue mozilla#2865
fzzzy pushed a commit that referenced this issue Sep 18, 2017
@lmorchard @fzzzy
Upload unsigned packaged add-on to dev & stage (#2870)
5d8258f 
- For dev & stage only:
  - Restore the *.xpi and *.rdf upload removed in #2651
  - Restore creation of /static/addon/latest redirect with add-on hash
  - Configure frontend app to install add-on from /static/addon/latest

Issue #2865
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 29
Development

No branches or pull requests
1 participant
@lmorchard