Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Require ENABLE_PONTOON=1 during frontend build to include Pontoon JS in pages #1361

Merged
merged 2 commits into from Sep 20, 2016

Conversation

lmorchard
Copy link
Contributor

Fixes #1356

@lmorchard
Copy link
Contributor Author

lmorchard commented Sep 15, 2016

This should exclude the Pontoon script tag by default on all pages, unless ENABLE_PONTOON=1 is set during frontend build. That's enabled in this PR for develpoment-static branch, but it should be off for any other deployments in the future.

You can test this locally by running gulp and verifying that there's no Pontoon script tag on the page. Restart with ENABLE_PONTOON=1 gulp and the script tag should appear.

Copy link

@chuckharmston chuckharmston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

Only nit: this seems like the sort of thing we should be documenting.

@ghost
Copy link

ghost commented Sep 16, 2016

Thanks for cooking this up, Les and for reviewing it, Chuck

@lmorchard
Copy link
Contributor Author

Only nit: this seems like the sort of thing we should be documenting.

Definitely a good point. One caveat is that the static build system isn't documented at all yet, so there's not really a good place to put just the mention of this flag right now. Hoping to work on those docs today for #1350

@lmorchard
Copy link
Contributor Author

May collide with PR #1366, but I added a section to deployment docs describing how ENABLE_PONTOON is used.

@lmorchard lmorchard merged commit e4fc807 into mozilla:master Sep 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants