Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

update tab center URL #1904

Merged
merged 1 commit into from Dec 2, 2016
Merged

update tab center URL #1904

merged 1 commit into from Dec 2, 2016

Conversation

clouserw
Copy link
Member

@clouserw clouserw commented Dec 2, 2016

No description provided.

@ghost ghost added the status: in progress label Dec 2, 2016
@pdehaan
Copy link
Contributor

pdehaan commented Dec 2, 2016

I think the only other non-conforming xpi_url in /api/experiments.json was the Universal Search one, but possibly not relevant due to retirement:

$ http https://testpilot.firefox.com/api/experiments.json | grep "xpi_url"

      "xpi_url": "https://testpilot.firefox.com/files/activitystream/latest",
      "xpi_url": "https://testpilot.firefox.com/files/min-vid/latest",
      "xpi_url": "https://testpilot.firefox.com/files/nomore404s/latest",
      "xpi_url": "https://testpilot.firefox.com/files/pageshot/latest",
      "xpi_url": "https://people.mozilla.org/~bwinton/TabCenter/tab-center.xpi",
      "xpi_url": "https://testpilot.firefox.com/files/blok/latest",
      "xpi_url": "https://s3-us-west-2.amazonaws.com/universal-search/universal-search.xpi",

@codecov-io
Copy link

Current coverage is 97.79% (diff: 100%)

Merging #1904 into master will not change coverage

@@             master      #1904   diff @@
==========================================
  Files            70         70          
  Lines          1769       1769          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1730       1730          
  Misses           39         39          
  Partials          0          0          

Powered by Codecov. Last update ce3c606...74ce038

@clouserw
Copy link
Member Author

clouserw commented Dec 2, 2016

thanks @pdehaan -- yeah, shouldn't be a problem now. We could probably strip all of that out if we wanted to bother.

@pdehaan
Copy link
Contributor

pdehaan commented Dec 2, 2016

But yeah, tested the new URL and it downloaded tab_center.xpi for me, so R+. 👍

Not to be too pedantic, but it downloaded tab-center.xpi, right? the one with the underscore was the old one

@lmorchard
Copy link
Contributor

Yup, downloaded tab-center.xpi for me. LGTM.
screenshot 2016-12-02 16 26 10

@lmorchard lmorchard merged commit 98852af into mozilla:master Dec 2, 2016
@ghost
Copy link

ghost commented Dec 5, 2016

Errr... I think I edited @pdehaan's comment instead of replying to it and quoting it. Sorry! Interneting is hard. Thanks for landing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants