This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Trigger the 'new' badge based on the locale/launch filtered experiment list #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannycoates
reviewed
Jan 6, 2017
| const created = new Date(experiment.created); | ||
| const launched = experiment.launch_date && new Date(experiment.launch_date); | ||
| return (created.getTime() > store.toolbarButtonLastClicked) || | ||
| (launched.getTime() > store.toolbarButtonLastClicked); |
pdehaan
reviewed
Jan 6, 2017
| const created = new Date(experiment.created); | ||
| const launched = experiment.launch_date && new Date(experiment.launch_date); | ||
| return (created.getTime() > store.toolbarButtonLastClicked) || | ||
| (launched.getTime() > store.toolbarButtonLastClicked); |
There was a problem hiding this comment.
I'm a bit confused on this line.
I think line 217 above is saying experiment.launch_date && which looks like it could almost return a false/undefined if launch_date wasn't somehow defined for an experiment.
Which if that boolean logic fails, and launched doesn't get set to a Date object, this line could fail as .getTime() would be trying to access a non-Date object here.
Maybe?
There was a problem hiding this comment.
yup, dcoates found the same potential bug 👍
jaredhirsch
force-pushed
the
1973-new-badge-filtering
branch
from
0716837
to
cd0d09e
Compare
dannycoates
approved these changes
Jan 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the 'new' badge isn't recalculated dynamically when the user's language preference changes. But it will only trigger in the case where the language isn't blocked and the launch_date is in the future. We could dynamically recalculate the 'new' badge, but that would expand the scope of this patch.
Fixes #1973.