This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Migrate UI to match Test Pilot updates #460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meandavejustice
force-pushed
the
wip-ui-migration
branch
from
9ab5abe
to
0143b0b
Compare
|
amended commit to fix view tests and rebase with master |
johngruen
force-pushed
the
wip-ui-migration
branch
from
0143b0b
to
241c466
Compare
|
here's what's left:
|
johngruen
force-pushed
the
wip-ui-migration
branch
from
241c466
to
08acffc
Compare
| } | ||
| } | ||
|
|
||
| // Image Manangement |
There was a problem hiding this comment.
well, this is spelled wrong!
There was a problem hiding this comment.
also @pdehaan sass-lint doesn't seem to do inline ignores...anyway this doesn't seem to work. Thoughts?
There was a problem hiding this comment.
@johngruen No they don't, although I was investigating yesterday for a different project and it doesn't look like it will be supported until v2.
Solutions:
- Ignore sass-lint warnings for now until they release v2.
- We can try and figure out how to ignore the one file that generates the warnings.
Neither is great, so we'd want to go with the lesser evil (even if that means moving the hidpi-background-image() mixin into its own file). Gross.
johngruen
force-pushed
the
wip-ui-migration
branch
3 times, most recently
from
3388c8e
to
41cfee6
Compare
| @@ -19,7 +19,6 @@ const sassLint = require('gulp-sass-lint'); | |||
| const source = require('vinyl-source-stream'); | |||
| const sourcemaps = require('gulp-sourcemaps'); | |||
| const through = require('through2'); | |||
| const tabzilla = require('mozilla-tabzilla'); | |||
There was a problem hiding this comment.
Are we not using mozilla-tabzilla anymore? Do we need to remove it from package.json?
meandavejustice
force-pushed
the
wip-ui-migration
branch
from
41cfee6
to
31c2498
Compare
johngruen
force-pushed
the
wip-ui-migration
branch
from
31c2498
to
f1a9717
Compare
| return runSequence([ | ||
| 'npm:tabzilla:img' | ||
| ], done); | ||
| }); |
There was a problem hiding this comment.
You'll need to remove the vendor task reference from gulp.task('build') on L141 below as well, since it's blowing up Travis-CI:
[22:23:14] Using gulpfile /home/travis/build/mozilla/testpilot/gulpfile.js
[22:23:14] Starting 'build'...
[22:23:14] 'build' errored after 1.09 ms
[22:23:14] Error: Task vendor is not configured as a task on gulp. If this is a submodule, you may need to use require('run-sequence').use(gulp).
at /home/travis/build/mozilla/testpilot/node_modules/run-sequence/index.js:20:10
at Array.forEach (native)
at verifyTaskSets (/home/travis/build/mozilla/testpilot/node_modules/run-sequence/index.js:13:11)
at runSequence (/home/travis/build/mozilla/testpilot/node_modules/run-sequence/index.js:94:2)
at Gulp.buildTask (/home/travis/build/mozilla/testpilot/gulpfile.js:139:3)
at module.exports (/home/travis/build/mozilla/testpilot/node_modules/gulp/node_modules/orchestrator/lib/runTask.js:34:7)
at Gulp.Orchestrator._runTask (/home/travis/build/mozilla/testpilot/node_modules/gulp/node_modules/orchestrator/index.js:273:3)
at Gulp.Orchestrator._runStep (/home/travis/build/mozilla/testpilot/node_modules/gulp/node_modules/orchestrator/index.js:214:10)
at Gulp.Orchestrator.start (/home/travis/build/mozilla/testpilot/node_modules/gulp/node_modules/orchestrator/index.js:134:8)
at /home/travis/build/mozilla/testpilot/node_modules/gulp/bin/gulp.js:129:20
at process._tickCallback (node.js:355:11)
at Function.Module.runMain (module.js:503:11)
at startup (node.js:129:16)
at node.js:814:3
f1a9717
to
3993222
Compare
meandavejustice
force-pushed
the
wip-ui-migration
branch
2 times, most recently
from
05b8af3
to
7a2014d
Compare
meandavejustice
changed the title
meandavejustice
force-pushed
the
wip-ui-migration
branch
4 times, most recently
from
848a151
to
43413fe
Compare
johngruen
force-pushed
the
wip-ui-migration
branch
from
43413fe
to
e740bf4
Compare
meandavejustice
force-pushed
the
wip-ui-migration
branch
from
e740bf4
to
0332d6b
Compare
johngruen
force-pushed
the
wip-ui-migration
branch
from
0332d6b
to
62e37f9
Compare
- apply new styles - handle some scss errors(waiting on sasstools/sass-lint#70 to silence some of the incorrect errors) - get l10n up to date with template changes - update client tests to pass - fixes #441
johngruen
force-pushed
the
wip-ui-migration
branch
from
62e37f9
to
7363e40
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to silence some of the incorrect errors)