This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
update add-on name #469
Merged
update add-on name #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,7 +16,7 @@ dev: [dev-prefs.json](dev-prefs.json) | |||
|
|
|||
| You may need to set both `xpinstall.signatures.required` and | |||
| `xpinstall.whitelist.required` flags to false in `about:config` | |||
| if the addon has not yet been signed. | |||
| if the add-on has not yet been signed. | |||
There was a problem hiding this comment.
Do we want to remove this section now that the addon add-on is signed, or is it still relevant for local development?
There was a problem hiding this comment.
Still relevant for local development - we have to bump the version each and every time we want a new signed XPI, so that's totally unworkable for local dev.
So, we use Fx Dev Edition, turn off sig checking, and run jpm watchpost via npm run watch along with the Extension Auto-installer.
|
@clouserw Could you rebase this with master when you get a free moment? |
|
rebased w/ master |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is low priority but: