Issue 1991 #2008
Issue 1991 #2008
Conversation
public/homepage/scripts/main.js
Outdated
| $.ajax({url: url, dataType: "text"}); | ||
| }); | ||
| //Using prefetch for easier cacheing and preloading of resources | ||
| <link rel="prefetch" href="/dist/styles/brackets.min.css"> |
There was a problem hiding this comment.
This is HTML, and you're putting it in a JavaScript file. You can't mix these. This would have to go in the HTML for the homepage, see https://github.com/mozilla/thimble.mozilla.org/blob/master/views/homepage/index.html.
Next issue: you need to fix the URLs you are loading, as these are going to try and load from the Thimble server.
|
Changing the way we do it to be more modern, less of a hack, and these 2 PRs can work together to achieve it. |
|
I realized my HTML in the Javascript mistake right after I pushed the changes - my bad! Hopefully this works - the reason I took a while to fix this was because I wanted to check if the loading was actually speeding up and I ran into some weird Vagrant error making insanely long Windows path names. |
|
I'm finishing this in #2234 |
Cleaning up the preloading of Bramble by using prefetch. Fixes #1991.
(Excuse the slight fumbling of this, I thought I could pull within the same issue number)
Realized my error and in the process of fixing it