[WIP] Fix issue 2012: Make remix button working #2027
Conversation
| @@ -188,12 +188,15 @@ define(["jquery", "analytics"], function($, analytics) { | |||
| newItem.find(".description").text(activity.description); | |||
|
|
|||
| // Check if activity_url ends with a slash, if it doesn't - add one before adding "remix" | |||
| var remix = "remix"; | |||
| /*var remix = "remix"; | |||
There was a problem hiding this comment.
no need to comment out all of this, just remove it.
| var endsWithSlash = (activity.url.charAt(activity.url.length-1) === "/"); | ||
| if(!endsWithSlash) { | ||
| remix = "/remix"; | ||
| } | ||
| newItem.find(".remix").attr("href", activity.url + remix); | ||
| */ | ||
| //WIP: see the discussion on: https://github.com/mozilla/thimble.mozilla.org/issues/2012 | ||
| newItem.find(".remix").attr("href", "https://thimble.mozilla.org/projects/" + (activity.url).match(/\d+/)[0] + "/remix"); |
There was a problem hiding this comment.
I'm going to suggest another fix here because regexing urls can be brittle.
@ZenanZha open up a PR against the https://github.com/mozilla/thimble-homepage-gallery repo and add a property to each object called projectID and let its value be the number at the end of the url property. FOr e.g.,
{
"title" : "Back to School Postcard",
"thumbnail_url" : "https://thimble.mozilla.org/img/thumbnail-postcard.png",
"url" : "https://thimbleprojects.org/mozillalearning/220079/",
"description" : "Add your own content to this interactive postcard.",
"tags" : ["images","code","javascript","interactive","js"],
"teaching_kit_url" : "https://thimbleprojects.org/mozillalearning/62/",
"featured" : true,
"author" : "mozilla",
"author_url" : "http://learning.mozilla.org"
}would change to
{
"title" : "Back to School Postcard",
"thumbnail_url" : "https://thimble.mozilla.org/img/thumbnail-postcard.png",
"url" : "https://thimbleprojects.org/mozillalearning/220079/",
"projectID" : 220079,
"description" : "Add your own content to this interactive postcard.",
"tags" : ["images","code","javascript","interactive","js"],
"teaching_kit_url" : "https://thimbleprojects.org/mozillalearning/62/",
"featured" : true,
"author" : "mozilla",
"author_url" : "http://learning.mozilla.org"
}Then, out here, change this line to:
newItem.find(".remix").attr("href", "/projects/" + activity.projectID + "/remix");There was a problem hiding this comment.
@gideonthomas
But what is the point for us to keep "url" in the file?
We didn't use it anywhere.
There was a problem hiding this comment.
because it stores the username part of the url which is needed.
|
@ZenanZha any updates on this? |
|
@ZenanZha still working on this? Mind if i take over ? |
|
Hi @Rajat-dhyani and @ZenanZha, this has become a critical bug that needs to be fixed so I think I'm gonna take over so that we can land this asap. Thank you for getting this started though! |
refer to this issue : mozilla/thimble.mozilla.org#2027
Refer to this :mozilla/thimble.mozilla.org#2027
|
No problem @gideonthomas Thanks for informing i was already working on this 👍 i will skip it |
|
Moved to #2051! |
This is a possible sulotion for issue2012.
Need more discussion on how to fix it, so I kept the old code.
Merge this would temporarily make remix button working again.
@gideonthomas @humphd