Skip to content
This repository has been archived by the owner on Jul 31, 2019. It is now read-only.

Fixed [904706] Thimble pages not scrollable on iOS #237

Closed
wants to merge 4 commits into from
Closed

Fixed [904706] Thimble pages not scrollable on iOS #237

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1726901
Fixed [904706] Thimble pages not scrollable on iOS
stanica Sep 29, 2013
2015972
Added newline to end of makedetails.less as per style guide
stanica Sep 30, 2013
a937bdb
Added min/max constraints for iPad resolution
stanica Sep 30, 2013
753041f
Merge branch 'master' into t904706
stanica Oct 10, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions public/stylesheets/makedetails.less
View file
Open in desktop
Expand Up @@ -199,3 +199,10 @@ body {
}
}

@media only screen and (device-width: 768px) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use device-width, use min or max width. Also, why 768? Put a comment about that

.thimble-project-container {
/* For iOS scrolling within iframe.*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In LESS your comments can be like this for single lines
// For iOS.....

overflow: auto;
-webkit-overflow-scrolling: touch;
}
}