This repository has been archived by the owner on Jul 31, 2019. It is now read-only.
Bug 863368 - Enable publishing to mywebmaker.org subdomains #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| path = originalURL[2], | ||
| subdomain = originalURL[1]; | ||
|
|
||
| req.publishedUrl = "https://" + subdomain + ".mywebmaker.org" + path; |
There was a problem hiding this comment.
Can you move mywebmaker.org into the env.dist file so we don't hard code it here?
There was a problem hiding this comment.
ideally, we'd also control the protocol. We want "always https", but do we want to hardcode that, or protocol-env-set it?
sedge
added a commit
to sedge/thimble.webmaker.org
that referenced
this pull request
Feb 20, 2015
sedge
added a commit
to sedge/thimble.webmaker.org
that referenced
this pull request
Feb 23, 2015
sedge
added a commit
to sedge/thimble.webmaker.org
that referenced
this pull request
Feb 26, 2015
sedge
added a commit
to sedge/thimble.webmaker.org
that referenced
this pull request
Mar 4, 2015
sedge
added a commit
to sedge/thimble.webmaker.org
that referenced
this pull request
May 8, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.