This repository has been archived by the owner on Jul 31, 2019. It is now read-only.
Stay Calm template for user testing, minor fix to node error handling #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,7 +14,7 @@ function renderError( err, res ) { | |||
| }); | |||
| } | |||
|
|
|||
| module.exports.errorHandler = function(err, req, res) { | |||
| module.exports.errorHandler = function(err, req, res, next) { | |||
There was a problem hiding this comment.
why do we pass in next if we're not calling it anywhere?
There was a problem hiding this comment.
It needs 4-args vs. 3 in order for express to treat it as error handling middleware, see http://expressjs.com/guide/error-handling.html
|
r=me with travis |
Fix travis failing on unused next var
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also slipped in a minor fix to the error handling middleware we use, which was wrong before.
This temporarily overrides how we do the default project content so @flukeout can do user testing, see https://github.com/mozilla/thimble.webmaker.org/issues/558#issuecomment-117259560