Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tlsAnalyzer does not declare its queue #25

Closed
jvehent opened this issue Apr 15, 2015 · 4 comments
Closed

tlsAnalyzer does not declare its queue #25

jvehent opened this issue Apr 15, 2015 · 4 comments
Labels

Comments

@jvehent
Copy link
Contributor

jvehent commented Apr 15, 2015

This call should be preceded by a queue declaration:
https://github.com/mozilla/TLS-Observer/blob/master/src/tlsAnalyser/tlsAnalyser.go#L239
(returned errors should be checked as well).

@0xdiba
Copy link
Contributor

0xdiba commented Apr 15, 2015

The queue is automatically declared by the amqpmodule wrapper I have built.
Don't know if its a good way to go, just wanted to take out logic from the
analysers.

You are absolutely right about the error handling.

Thanks for checking out the code ;) .

On Wed, Apr 15, 2015 at 4:00 PM, Julien Vehent notifications@github.com
wrote:

This call should be preceded by a queue declaration:

https://github.com/mozilla/TLS-Observer/blob/master/src/tlsAnalyser/tlsAnalyser.go#L239
(returned errors should be checked as well).


Reply to this email directly or view it on GitHub
#25.

@0xdiba 0xdiba added the bug label Apr 15, 2015
@jvehent
Copy link
Contributor Author

jvehent commented Apr 16, 2015

Ha, so, I think if you just add the queue name to this call instead of "" it will work 🌴
https://github.com/mozilla/TLS-Observer/blob/master/src/modules/amqpmodule/amqpmodule.go#L128

@0xdiba
Copy link
Contributor

0xdiba commented Apr 16, 2015

Oooops....

On Thu, Apr 16, 2015 at 3:21 PM, Julien Vehent notifications@github.com
wrote:

Ha, so, I think if you just add the queue name to this call instead of ""
it will work [image: 🌴]

https://github.com/mozilla/TLS-Observer/blob/master/src/modules/amqpmodule/amqpmodule.go#L128


Reply to this email directly or view it on GitHub
#25 (comment).

@0xdiba
Copy link
Contributor

0xdiba commented Apr 21, 2015

Relates to issue #27

@0xdiba 0xdiba closed this as completed Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants