Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on a certificate that chain to Symantec roots #298

Closed
jcjones opened this issue Feb 23, 2018 · 5 comments
Closed

Warn on a certificate that chain to Symantec roots #298

jcjones opened this issue Feb 23, 2018 · 5 comments

Comments

@jcjones
Copy link

jcjones commented Feb 23, 2018

Trust paths which anchor to Symantec roots in this list are generally distrusted in Firefox 60 (based on a notBefore check) or Firefox 63 (no notBefore check). There's also a whitelist of some intermediates' SPKIs from Apple, Google, and DigiCert.

It would be nice to provide a warning and a link to the Upcoming_Distrust_Actions wiki either:

  1. If there's a Symantec root at the anchor, and a message saying "this might not work if it's not from one of the narrow whitelists", or
  2. Apply the Symantec blacklist and the SPKI whitelist and be very clear that this is broken or about to be broken.

The notBefore check seems unnecessary to duplicate, as all of these certs need to change.

@jcjones
Copy link
Author

jcjones commented Feb 23, 2018

Another way to handle this is by blacklist of the actual end entity certificates. I believe Sleevi is producing one, so could just do a lookup of those, as we have a complete list.

@jvehent
Copy link
Contributor

jvehent commented Feb 24, 2018

If a cert has two paths, and only one goes through a distrusted root, what should the result of the analysis be?

@floatingatoll
Copy link

floatingatoll commented Feb 24, 2018 via email

@jvehent
Copy link
Contributor

jvehent commented Feb 27, 2018

This has been implemented in #299 and is currently running in production.

@jvehent
Copy link
Contributor

jvehent commented May 29, 2018

for archiving, the sql queries that produce the report:

SELECT COUNT(DISTINCT(target)) AS "Sample size"
FROM scans
  INNER JOIN analysis ON (scans.id=analysis.scan_id)
  INNER JOIN certificates ON (scans.cert_id=certificates.id)
WHERE has_tls=true
  AND worker_name='symantecDistrust'
  AND timestamp > '2018-05-16 08:00:00';

SELECT COUNT(DISTINCT(target)) AS "Distrusted in 60"
FROM scans
  INNER JOIN analysis ON (scans.id=analysis.scan_id)
  INNER JOIN certificates ON (scans.cert_id=certificates.id)
WHERE has_tls=true
  AND worker_name='symantecDistrust'
  AND timestamp > '2018-05-16 08:00:00'
  AND not_valid_before < '2016-06-01'
  AND CAST(output->>'isDistrusted' AS BOOLEAN) = true;

SELECT COUNT(DISTINCT(target)) AS "Distrusted in 60 but expire before release"
FROM scans
  INNER JOIN analysis ON (scans.id=analysis.scan_id)
  INNER JOIN certificates ON (scans.cert_id=certificates.id)
WHERE has_tls=true
  AND worker_name='symantecDistrust'
  AND timestamp > '2018-05-16 08:00:00'
  AND not_valid_before < '2016-06-01' AND not_valid_after < '2018-05-09'
  AND CAST(output->>'isDistrusted' AS BOOLEAN) = true;

SELECT COUNT(DISTINCT(target)) AS "Distrusted in 63"
FROM scans
  INNER JOIN analysis ON (scans.id=analysis.scan_id)
  INNER JOIN certificates ON (scans.cert_id=certificates.id)
WHERE has_tls=true
  AND worker_name='symantecDistrust'
  AND timestamp > '2018-05-16 08:00:00'
  AND CAST(output->>'isDistrusted' AS BOOLEAN) = true;

SELECT COUNT(DISTINCT(target)) AS "Distrusted in 63 but expire before release"
FROM scans
  INNER JOIN analysis ON (scans.id=analysis.scan_id)
  INNER JOIN certificates ON (scans.cert_id=certificates.id)
WHERE has_tls=true
  AND worker_name='symantecDistrust'
  AND timestamp > '2018-05-16 08:00:00' AND not_valid_after < '2018-10-16'
  AND CAST(output->>'isDistrusted' AS BOOLEAN) = true;

SELECT COUNT(DISTINCT(target)) AS "Sites impacted after 63 release if current cert is maintained"
FROM scans
  INNER JOIN analysis ON (scans.id=analysis.scan_id)
  INNER JOIN certificates ON (scans.cert_id=certificates.id)
WHERE has_tls=true
  AND worker_name='symantecDistrust'
  AND timestamp > '2018-05-16 08:00:00' AND not_valid_after > '2018-10-16'
  AND CAST(output->>'isDistrusted' AS BOOLEAN) = true;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants