-
Notifications
You must be signed in to change notification settings - Fork 68
Conversation
cca309e
to
3382e1b
Compare
efb3c42
to
39fc72d
Compare
Is this ultimately planning to land in a branch for a particular experiment or on master? |
Discussed this in the meeting today, and sounds like it's fine to land this on master with the knowledge that we might want to ultimately hide the 'overview' button or other UI elements while testing other features. IOW we can consider the top bar / nav bar changes present here the new 'default' UI. @phlsa please correct me if that's wrong. |
ac5dc87
to
53b2882
Compare
9867d25
to
cfb47f1
Compare
Landed some of the changes in 9770df4 Further commits will follow in this PR. |
feebc67
to
b4f00d7
Compare
Signed-off-by: Victor Porof <vporof@mozilla.com>
…ies are visible Signed-off-by: Victor Porof <vporof@mozilla.com>
Signed-off-by: Victor Porof <vporof@mozilla.com>
Signed-off-by: Victor Porof <vporof@mozilla.com>
Signed-off-by: Victor Porof <vporof@mozilla.com>
cd35541
to
5731106
Compare
Rebased. |
@@ -55,6 +55,17 @@ export default function uiState(state = initialState, action) { | |||
case types.SET_URL_INPUT_AUTOCOMPLETE_INDEX: | |||
return state.set('focusedResultIndex', action.payload.index); | |||
|
|||
case types.TOGGLE_PAGE_SUMMARIES: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've decided in the past to not use TOGGLE_* as an action, instead preferring SET_* so that the action log / frontend is more explicit about what it's requesting. See something like SET_URL_INPUT_VISIBLE as an example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed on this
This looks overall good to me -- some visual bugs that Brian pointed out, but easier to fix it with it landed, and can begin tackling the harder issue of custom cards |
@bgrins passed this over to me -- after looking through the code, I don't have really any comments other than the naming of the action and maybe the granularity of some of the views, like Thumbnail and FittedImage, especially as we don't have other consumers of those (yet -- maybe you're anticipating some things). Or maybe just a preference. Either way, some of the lower level components could benefit from brief comment descriptions on how/when to use them (if I'm building something else looking at components, I should be able to quickly know when I'd use thumbnail vs fitted image). Looks great! Once landed we can file follow up bugs and tackle the custom cards. |
@bgrins But since I'm not really sure, I'll land as is and we can get @phlsa's feedback later. |
@jsantell FittedImage and Thumbnail both have comments that describe what they're intended for. Granular components are always a good idea, and incredibly useful once we properly start using |
I'm not entirely sure what you are referring to @victorporof. |
…ying on a toggle mechanism Signed-off-by: Victor Porof <vporof@mozilla.com>
Signed-off-by: Victor Porof <vporof@mozilla.com>
Signed-off-by: Victor Porof <vporof@mozilla.com>
Signed-off-by: Victor Porof <vporof@mozilla.com>
Signed-off-by: Victor Porof <vporof@mozilla.com>
Signed-off-by: Victor Porof <vporof@mozilla.com>
Signed-off-by: Victor Porof <vporof@mozilla.com>
Signed-off-by: Victor Porof <vporof@mozilla.com>
5731106
to
c221d10
Compare
Fixes #747
Looking to start landing this incrementally. Here's a first couple of commits.
A few more coming soon after I finish cleaning up.
@bgrins