Skip to content
This repository has been archived by the owner on Mar 21, 2018. It is now read-only.

Make app state dependencies more explicit #304

Merged
merged 2 commits into from Apr 29, 2016

Conversation

linclark
Copy link
Contributor

@jsantell I'm going to break up the reducer refactor into pieces to make it easier to review. This should also help us avoid stepping on each other's toes too much as we both work on the reducers.

This is the first piece.

@coveralls
Copy link

coveralls commented Apr 29, 2016

Coverage Status

Coverage decreased (-0.02%) to 39.969% when pulling 4edc203 on linclark:app-state-deps into 935c0d0 on mozilla:master.

@jsantell
Copy link
Contributor

LGTM! Should these helpers be in reducers, though, if not used as a redux reducer? Even like ./reducers/helpers.js maybe? I don't feel strongly though

@linclark
Copy link
Contributor Author

Good idea. We will probably have a lot more, so we probably don't want to put it in the same file. Looking back at the Redux docs for selectors, it looks like that uses a selectors/ dir.

I'll do that as part of the follow ups to this one.

@linclark linclark merged commit 7730f60 into mozilla:master Apr 29, 2016
@linclark linclark deleted the app-state-deps branch May 2, 2016 20:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants