This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Bug 1077635 - Improve readability of platform job rows #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work fixes Bugzilla bug 1077635.
The change improves readability of the job content, by aligning the platform name with its adjacent job block like TPBL, and enhancing beyond TBPL with a platform row color, to help quickly grok the content when Sheriffs are glancing at it.
Here is current production (centered platform name, all white):
Here is the proposed appearance (aligned platform name,
#f8f8f8
alternate grey):Here the same change with pending jobs, which looks very nice:
I also did another alternate, which adds a 1px subtle row border as an option. However it cumulatively adds about 20-30px vertically to a given result set.
I've checked on a couple of different monitors with different amounts of luminance and display quality, and the
#f8f8f8
background seems to show up well, without interfering with the pending job color. By not going too dark, it also still keeps the overall feel of a unified result set block.We may want to darken the hover color slightly for more differentiation, when hovering over an already grey row, but it seemed ok on my local server.
Tested on Windows:
FF Release 32.0.3
Chrome Latest Release 37.0.2062.124 m
Adding @edmorley and @rvandermeulen for evaluation and @camd for review.