Skip to content
This repository has been archived by the owner on Nov 10, 2017. It is now read-only.

Bug 1077635 - Improve readability of platform job rows #216

Merged
merged 1 commit into from Oct 6, 2014

Conversation

tojon
Copy link

@tojon tojon commented Oct 5, 2014

This work fixes Bugzilla bug 1077635.

The change improves readability of the job content, by aligning the platform name with its adjacent job block like TPBL, and enhancing beyond TBPL with a platform row color, to help quickly grok the content when Sheriffs are glancing at it.

Here is current production (centered platform name, all white):

jobrowcurrent

Here is the proposed appearance (aligned platform name, #f8f8f8 alternate grey):

jobrowproposed

Here the same change with pending jobs, which looks very nice:

pendingexampleproposed

I also did another alternate, which adds a 1px subtle row border as an option. However it cumulatively adds about 20-30px vertically to a given result set.

jobrowalternate

I've checked on a couple of different monitors with different amounts of luminance and display quality, and the #f8f8f8 background seems to show up well, without interfering with the pending job color. By not going too dark, it also still keeps the overall feel of a unified result set block.

We may want to darken the hover color slightly for more differentiation, when hovering over an already grey row, but it seemed ok on my local server.

Tested on Windows:
FF Release 32.0.3
Chrome Latest Release 37.0.2062.124 m

Adding @edmorley and @rvandermeulen for evaluation and @camd for review.

@tojon
Copy link
Author

tojon commented Oct 6, 2014

Both @edmorley and @rvandermeulen mentioned in the bug they'd like to try the last one with the 1px border, even though it will consume more space. I will push that change shortly.

@tojon
Copy link
Author

tojon commented Oct 6, 2014

@camd now ready for review and push to dev, for live sheriff evaluation.

@camd
Copy link

camd commented Oct 6, 2014

Sounds great. Let's go with it and see how people like it. :)

camd pushed a commit that referenced this pull request Oct 6, 2014
Bug 1077635 - Improve readability of platform job rows
@camd camd merged commit 027a574 into mozilla:master Oct 6, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants