This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Bug 1146651 - Remove legacy per-resultset filter code #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camd
pushed a commit
that referenced
this pull request
Mar 31, 2015
Bug 1146651 - Remove legacy per-resultset filter code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Bugzilla bug 1146651
This removes references to per-resultset filters and related code.
resultSetFilterChangedappeared it could be retired also.resultStatusFiltersis still used for global filters.Everything seems fine running locally, adding and removing Global filters, adding and removing custom text filters via 'Filter Platforms & Jobs' on both browsers.
I also tweaked adjacent comments referencing local filters.
I briefly searched treeherder-service out of interest, I didn't see anything obvious there that corresponded or would need removal.
Tested on OSX 10.9.5:
FF Release 36.0.4
Chrome Latest Release 41.0.2272.104 (64-bit)
Adding @camd for review.