Skip to content
This repository has been archived by the owner on Nov 10, 2017. It is now read-only.

Bug 1162706 - Add UI access between treeherder and perfherder #520

Merged
merged 1 commit into from
May 12, 2015

Conversation

tojon
Copy link

@tojon tojon commented May 12, 2015

This work fixes Bugzilla bug 1162706.

This converts our inert Treeherder and Perfherder 'logos' into equivalent nav menus, so you can switch back and forth between platforms, and discover Perfherder from Treeherder.

Here's current (inert logo):

current

Here's Treeherder proposed (menu posted):

treeherderproposed1a

We consciously use the same style as our other right hand nav bar buttons, to cue the user it is navigable, and for consistency. I don't see a downside to that approach.

Here's the proposed tooltip for both:

perftooltipproposed

Here's Perfherder proposed (menu posted):

perfproposed

The only workflow I discovered that doesn't work as expected, is if you use the Perfherder menu to navigate to Treeherder, and then hit 'back' on your browser, we just reload Treeherder instead of reloading Perfherder. The other direction is fine. I wonder if it related to our hash routing or my -ui local server development configuration. I will poke around a bit more on that. That being said, you can use the menu to easily navigate back.

Otherwise everything seems fine.

Tested on OSX 10.10.3:
FF Release 37.0.2
FF Nightly 40.0a1
Chrome Latest Release 42.0.2311.135 (64-bit)

Adding @wlach for review and @jmaher for visibility.

Review on Reviewable

.navbar-inverse .navbar-brand:hover {
color: #777;
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retiring these bootstrap overrides, they are no longer needed.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

@tojon
Copy link
Author

tojon commented May 12, 2015

I had one other tweak to make also; to get the treeherder link working correctly which I think will mimic its behavior on our instances. From (web-server.js) treeherder.html to /# (vagrant). It seems fine in vagrant, so I will merge now.

@tojon tojon merged commit 27ba5b3 into mozilla:master May 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants