This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Bug 1162706 - Add UI access between treeherder and perfherder #520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work fixes Bugzilla bug 1162706.
This converts our inert Treeherder and Perfherder 'logos' into equivalent nav menus, so you can switch back and forth between platforms, and discover Perfherder from Treeherder.
Here's current (inert logo):
Here's Treeherder proposed (menu posted):
We consciously use the same style as our other right hand nav bar buttons, to cue the user it is navigable, and for consistency. I don't see a downside to that approach.
Here's the proposed tooltip for both:
Here's Perfherder proposed (menu posted):
The only workflow I discovered that doesn't work as expected, is if you use the Perfherder menu to navigate to Treeherder, and then hit 'back' on your browser, we just reload Treeherder instead of reloading Perfherder. The other direction is fine. I wonder if it related to our hash routing or my -ui local server development configuration. I will poke around a bit more on that. That being said, you can use the menu to easily navigate back.
Otherwise everything seems fine.
Tested on OSX 10.10.3:
FF Release 37.0.2
FF Nightly 40.0a1
Chrome Latest Release 42.0.2311.135 (64-bit)
Adding @wlach for review and @jmaher for visibility.