This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
Bug 1164209 - Fix page flash when UI switching from Perf to Treeherder #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (hopefully) fixes Bugzilla bug 1164209.
Basically we adjust the href on Perfherder side, so when we switch back to Treeherder we don't touch an empty
/#fragment and instead just start at/. This still works fine with vagrant for local development.I can mimic the problem and the fix on stage, simulating our new UI navigation menus by:
(problem)
(fix)
Given vagrant masks the problem for local development, I can't really prove it's working until we push to stage. But I think it will be fine.
Tested on OSX 10.10.3:
FF Release 37.0.2
FF Nightly 40.0a1
Chrome Latest Release 42.0.2311.135 (64-bit)
Adding @wlach for review.