Bug 1505758 - Fix/enable ESLint 'no-useless-escape'

https://eslint.org/docs/rules/no-useless-escape
mozilla · Nov 8, 2018 · 0e8406a · 0e8406a
1 parent 4ea8abe
commit 0e8406a
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 5 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -41,7 +41,6 @@ module.exports = {
     'no-restricted-syntax': 'off',
     'no-shadow': 'off',
     'no-underscore-dangle': 'off',
-    'no-useless-escape': 'off',
     'object-curly-newline': 'off',
     'object-shorthand': 'off',
     'operator-linebreak': 'off',

diff --git a/ui/helpers/autoclassify.jsx b/ui/helpers/autoclassify.jsx
@@ -16,7 +16,7 @@ export const stringOverlap = function (str1, str2) {
     })
     .map(function (str) {
       // Split into tokens on whitespace / ,  and |
-      return str.split(/[\s\/\,|]+/).filter(function (x) {
+      return str.split(/[\s/,|]+/).filter(function (x) {
         return x !== '';
       });
     });

diff --git a/ui/helpers/revision.js b/ui/helpers/revision.js
@@ -23,7 +23,7 @@ export const getRevisionTitle = function getRevisionTitle(revisions) {
     title = title.replace(/\btry: .*/, '');
     title = title.replace(/\b(r|sr|f|a)=.*/, '');
     title = title.replace(/(imported patch|\[mq\]:) /, '');
-    title = title.replace(/[;,\-\. ]+$/, '').trim();
+    title = title.replace(/[;,\-. ]+$/, '').trim();
     if (title) {
       if (title.length > thTitleSuffixLimit) {
         title = `${title.substr(0, thTitleSuffixLimit - 3)}...`;

diff --git a/ui/job-view/pushes/PushHeader.jsx b/ui/job-view/pushes/PushHeader.jsx
@@ -18,7 +18,7 @@ const SKIPPED_LINK_PARAMS = [
 ];
 
 function Author(props) {
-  const authorMatch = props.author.match(/\<(.*?)\>+/);
+  const authorMatch = props.author.match(/<(.*?)>+/);
   const authorEmail = authorMatch ? authorMatch[1] : props.author;
 
   return (

diff --git a/ui/js/controllers/perf/graphs.js b/ui/js/controllers/perf/graphs.js
@@ -1,5 +1,5 @@
 // Remove the eslint-disable when rewriting this file during the React conversion.
-/* eslint-disable no-use-before-define, no-var, prefer-template, radix, vars-on-top */
+/* eslint-disable no-use-before-define, no-useless-escape, no-var, prefer-template, radix, vars-on-top */
 // TODO: Vet/fix the use-before-defines to ensure switching var
 // to let/const won't break anything.