Skip to content

Commit

Permalink
Bug 1100328 - remove $cookies and localStorage from dependency
Browse files Browse the repository at this point in the history
injection where not needed
  • Loading branch information
maurodoglio committed Nov 17, 2014
1 parent 2df8878 commit 31c6859
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions ui/js/controllers/filters.js
Expand Up @@ -6,11 +6,11 @@

treeherder.controller('FilterPanelCtrl', [
'$scope', '$rootScope', '$route', '$routeParams', '$location', 'ThLog',
'localStorageService', 'thResultStatusList', 'thEvents', 'thJobFilters',
'thResultStatusList', 'thEvents', 'thJobFilters',
'ThResultSetModel', 'thPinboard', 'thNotify', 'thFailureResults',
function FilterPanelCtrl(
$scope, $rootScope, $route, $routeParams, $location, ThLog,
localStorageService, thResultStatusList, thEvents, thJobFilters,
thResultStatusList, thEvents, thJobFilters,
ThResultSetModel, thPinboard, thNotify, thFailureResults) {

var $log = new ThLog(this.constructor.name);
Expand Down
8 changes: 4 additions & 4 deletions ui/js/controllers/jobs.js
Expand Up @@ -5,13 +5,13 @@
"use strict";

treeherder.controller('JobsCtrl', [
'$scope', '$http', '$rootScope', '$routeParams', 'ThLog', '$cookies',
'localStorageService', 'thUrl', 'ThRepositoryModel', 'thDefaultRepo',
'$scope', '$http', '$rootScope', '$routeParams', 'ThLog',
'thUrl', 'ThRepositoryModel', 'thDefaultRepo',
'ThResultSetModel', 'thResultStatusList', '$location', 'thEvents',
'ThJobModel',
function JobsCtrl(
$scope, $http, $rootScope, $routeParams, ThLog, $cookies,
localStorageService, thUrl, ThRepositoryModel, thDefaultRepo,
$scope, $http, $rootScope, $routeParams, ThLog,
thUrl, ThRepositoryModel, thDefaultRepo,
ThResultSetModel, thResultStatusList, $location, thEvents, ThJobModel) {

var $log = new ThLog(this.constructor.name);
Expand Down
4 changes: 2 additions & 2 deletions ui/js/controllers/main.js
Expand Up @@ -6,13 +6,13 @@

treeherder.controller('MainCtrl', [
'$scope', '$rootScope', '$routeParams', '$location', 'ThLog',
'localStorageService', 'ThRepositoryModel', 'thPinboard',
'ThRepositoryModel', 'thPinboard',
'thClassificationTypes', 'thEvents', '$interval', '$window',
'ThExclusionProfileModel', 'thJobFilters', 'ThResultSetModel',
'thDefaultRepo',
function MainController(
$scope, $rootScope, $routeParams, $location, ThLog,
localStorageService, ThRepositoryModel, thPinboard,
ThRepositoryModel, thPinboard,
thClassificationTypes, thEvents, $interval, $window,
ThExclusionProfileModel, thJobFilters, ThResultSetModel,
thDefaultRepo) {
Expand Down
4 changes: 2 additions & 2 deletions ui/js/directives/persona.js
Expand Up @@ -5,10 +5,10 @@
'use strict';

treeherder.directive('personaButtons', [
'$http', '$q', '$log', '$rootScope', 'localStorageService',
'$http', '$q', '$log', '$rootScope',
'thServiceDomain', 'BrowserId', 'ThUserModel',
function(
$http, $q, $log, $rootScope, localStorageService, thServiceDomain,
$http, $q, $log, $rootScope, thServiceDomain,
BrowserId, ThUserModel) {

return {
Expand Down

0 comments on commit 31c6859

Please sign in to comment.