Bug 1329992 - Fix resultset status endpoint (#2079)

The way we were using Django's "annotate" function with values_list resulted in non-deterministic output.
mozilla · Jan 11, 2017 · 624132c · 624132c
1 parent 1ef2306
commit 624132c
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/treeherder/model/models.py b/treeherder/model/models.py
@@ -141,9 +141,9 @@ def get_status(self, exclusion_profile="default"):
         total_num_coalesced = 0
         for (state, result, total, num_coalesced) in jobs.values_list(
                 'state', 'result').annotate(
-                    total=Count('result'),
-                    num_coalesced=Count(Case(When(
-                        coalesced_to_guid__isnull=False, then=1)))):
+                    total=Count('result')).annotate(
+                        num_coalesced=Count(Case(When(
+                            coalesced_to_guid__isnull=False, then=1)))):
             total_num_coalesced += num_coalesced
             if state == 'completed':
                 status_dict[result] = total - num_coalesced