Bug 1398386 - Remove exclusion editor admin panel

docs/common_tasks.rst

@@ -163,6 +163,20 @@ Releasing a new version of the Python client
   and wheel releases (plus any new dependent packages) be added to the
   internal PyPI mirror. For an example, see `bug 1236965`_.
 
+Hide Jobs with Tiers
+--------------------
+
+To hide jobs we use the job's ``tier`` setting.  Jobs with ``tier`` of 3 are
+hidden by default.  There are two ways to set a job to be hidden in Treeherder:
+
+* TaskCluster - Edit the task definition to include the ``tier`` setting in
+  the Treeherder section.
+* BuildBot - You must get the signature hash of the job from the UI and add that
+  signature hash to the ``buildapi.py`` file in the Treeherder repo.  To get
+  the signature, click the job and then click the ``sig`` link in the Job
+  Details Panel.  That will place the signature hash in the filter field.
+
+
 .. _client Git log: https://github.com/mozilla/treeherder/commits/master/treeherder/client
 .. _client.py: https://github.com/mozilla/treeherder/blob/master/treeherder/client/thclient/client.py
 .. _bug 1236965: https://bugzilla.mozilla.org/show_bug.cgi?id=1236965

docs/testcases.rst

@@ -314,12 +314,6 @@ Warning: With the latest volume of jobs and pushes, anything greater than a sing
 
     **Expected**: pushes loaded should continue to honor that range.
 
-Modify Exclusion Profiles in the Sheriff panel
-------
-Open the Sheriffing panel in the top navbar, and change the Default exclusion to any other exclusion profile (eg. Test, Tier-2), by clicking on Make Default. Close the panel and reload the page.
-
-    **Expected**: Jobs present in that new profile should be excluded from the Job table, when the Show/Hide excluded job button is in its On (open square) state.
-
 Show/Hide excluded jobs
 ------
 Click the open rounded-square button in the top navbar to Show/Hide excluded jobs.

neutrino-custom/base.js

@@ -10,7 +10,6 @@ const SRC = path.join(CWD, 'src'); // neutrino's default source directory
 const UI = path.join(CWD, 'ui');
 const DIST = path.join(CWD, 'dist');
 const INDEX_TEMPLATE = path.join(UI, 'index.html');
-const ADMIN_TEMPLATE = path.join(UI, 'admin.html');
 const PERF_TEMPLATE = path.join(UI, 'perf.html');
 const LOGVIEWER_TEMPLATE = path.join(UI, 'logviewer.html');
 const FAILUREVIEWER_TEMPLATE = path.join(UI, 'failureviewer.html');
@@ -49,10 +48,6 @@ module.exports = neutrino => {
         .add(path.join(UI, 'entry-index.js'))
         .end();
     // Add several other treeherder entry points:
-    neutrino.config
-        .entry('admin')
-        .add(path.join(UI, 'entry-admin.js'))
-        .end();
     neutrino.config
         .entry('perf')
         .add(path.join(UI, 'entry-perf.js'))
@@ -82,7 +77,7 @@ module.exports = neutrino => {
         .rule('html')
         ._exclude
         .add([USERGUIDE_TEMPLATE, PERF_TEMPLATE, LOGVIEWER_TEMPLATE,
-            INDEX_TEMPLATE, ADMIN_TEMPLATE, FAILUREVIEWER_TEMPLATE]);
+            INDEX_TEMPLATE, FAILUREVIEWER_TEMPLATE]);
 
     // Don't use file loader for html...
     neutrino.config
@@ -109,16 +104,6 @@ module.exports = neutrino => {
             minify: HTML_MINIFY_OPTIONS
         });
 
-    neutrino.config
-        .plugin('html-admin')
-        .use(HtmlPlugin, {
-            inject: 'body',
-            filename: 'admin.html',
-            template: ADMIN_TEMPLATE,
-            chunks: ['admin', 'vendor', 'manifest'],
-            minify: HTML_MINIFY_OPTIONS
-        });
-
     neutrino.config
         .plugin('html-perf')
         .use(HtmlPlugin, {
@@ -186,7 +171,6 @@ module.exports = neutrino => {
             treeherder: require.resolve(path.join(UI, 'js/treeherder.js')),
             treeherderApp: require.resolve(path.join(UI, 'js/treeherder_app.js')),
             perf: require.resolve(path.join(UI, 'js/perf.js')),
-            admin: require.resolve(path.join(UI, 'js/admin.js')),
             failureViewerApp: require.resolve(path.join(UI, 'js/failureviewer.js')),
             logViewerApp: require.resolve(path.join(UI, 'js/logviewer.js')),
             userguideApp: require.resolve(path.join(UI, 'js/userguide.js'))

neutrino-custom/lint.js

@@ -45,9 +45,9 @@ module.exports = neutrino => {
                     'indent': ['error', 4, {
                         'SwitchCase': 1
                     }],
-                    'key-spacing': ['error', { 
-                        beforeColon: false, 
-                        afterColon: true 
+                    'key-spacing': ['error', {
+                        beforeColon: false,
+                        afterColon: true
                     }],
                     'keyword-spacing': 'error',
                     'linebreak-style': 'error',
@@ -103,16 +103,16 @@ module.exports = neutrino => {
                         asyncArrow: 'always'
                     }],
                     'strict': ['error', 'global'],
-                    'quote-props': ['error', 'as-needed', { 
-                        keywords: false, 
-                        unnecessary: true, 
-                        numbers: false 
+                    'quote-props': ['error', 'as-needed', {
+                        keywords: false,
+                        unnecessary: true,
+                        numbers: false
                     }],
                     'yoda': 'error'
                 },
                 globals: ['angular', '$', '_', 'treeherder', 'perf',
                     'treeherderApp', 'failureViewerApp', 'logViewerApp',
-                    'userguideApp', 'admin', 'Mousetrap', 'jQuery', 'React',
+                    'userguideApp', 'Mousetrap', 'jQuery', 'React',
                     'hawk', 'jsonSchemaDefaults', 'SERVICE_DOMAIN', 'numeral',
                     'metrics-graphics'
                 ]

tests/ui/unit/init.js

@@ -27,7 +27,6 @@ require('../../../ui/vendor/resizer.js');
 const jsContext = require.context('../../../ui/js', true, /^\.\/.*\.jsx?$/);
 window.treeherder = jsContext('./treeherder.js');
 window.treeherderApp = jsContext('./treeherder_app.js');
-window.admin = jsContext('./admin.js');
 window.perf = jsContext('./perf.js');
 window.failureViewerApp = jsContext('./failureviewer.js');
 window.logViewerApp = jsContext('./logviewer.js');

ui/entry-index.js

@@ -62,8 +62,6 @@ require('./js/models/bug_job_map.js');
 require('./js/models/classification.js');
 require('./js/models/job.js');
 require('./js/models/runnable_job.js');
-require('./js/models/job_exclusion.js');
-require('./js/models/exclusion_profile.js');
 require('./js/models/build_platform.js');
 require('./js/models/job_type.js');
 require('./js/models/job_group.js');