Bug 1370144 - Fix the Push author tooltip (#2541) r=emorley

mozilla · Jun 30, 2017 · 89e648b · 89e648b
1 parent d7fda53
commit 89e648b
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/ui/js/directives/treeherder/resultsets.js b/ui/js/directives/treeherder/resultsets.js
@@ -39,17 +39,12 @@ treeherder.directive('thAuthor', function () {
     return {
         restrict: "E",
         link: function (scope, element, attrs) {
-            var userTokens = attrs.author.split(/[<>]+/);
-            var email = "";
-            if (userTokens.length > 1) {
-                email = userTokens[1];
-            }
-            scope.authorName = userTokens[0].trim();
-            scope.authorEmail = email;
+            var authorMatch = attrs.author.match(/\<(.*?)\>+/);
+            scope.authorEmail = authorMatch ? authorMatch[1] : attrs.author;
         },
-        template: '<span title="View pushes by {{authorEmail}}">' +
+        template: '<span title="View pushes by this user">' +
             '<a href="{{authorResultsetFilterUrl}}"' +
-            'data-ignore-job-clear-on-click>{{authorName}}</a></span>'
+            'data-ignore-job-clear-on-click>{{authorEmail}}</a></span>'
     };
 });