Skip to content

Commit

Permalink
Bug 1066989 - Fix the treestatus and clobberer URLs for Thunderbird
Browse files Browse the repository at this point in the history
Now that bug 1035222 has corrected the base repo name, the clobberer
workaround added by bug 1035220 must be removed - and the treestatus
name generation tweaked.
  • Loading branch information
Ed Morley committed Sep 13, 2014
1 parent 94ccb27 commit a481017
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 10 deletions.
2 changes: 0 additions & 2 deletions ui/js/directives/top_nav_bar.js
Expand Up @@ -105,8 +105,6 @@ treeherder.directive('thRepoDropDown', [

scope.name = attrs.name;
scope.treeStatus = treeStatus.getTreeStatusName(attrs.name);
var clobberer = scope.treeStatus.split('-');
scope.clobberer = clobberer[0] + "-" + clobberer[1];
var repo_obj = ThRepositoryModel.getRepo(attrs.name);
scope.pushlog = repo_obj.url +"/pushloghtml";

Expand Down
10 changes: 3 additions & 7 deletions ui/js/services/treestatus.js
Expand Up @@ -9,13 +9,9 @@ treeherder.factory('treeStatus', [
var getTreeStatusName = function(name) {
// the thunderbird names in treestatus.mozilla.org don't match what
// we use, so translate them. pretty hacky, yes...
if (name.indexOf("thunderbird") >= 0) {
if (name === "thunderbird-trunk") {
return "comm-central-thunderbird";
} else {
var tokens = name.split("-");
return "comm-" + tokens[1] + "-" + tokens[0];
}
// TODO: Move these to the repository fixture in the service.
if (name.indexOf("comm-") >= 0 && name !== "try-comm-central") {
return name + "-thunderbird";
}
return name;
};
Expand Down
2 changes: 1 addition & 1 deletion ui/partials/thRepoDropDown.html
Expand Up @@ -20,7 +20,7 @@
</li>

<li class="watched-repo-dropdown-item">
<a href="https://secure.pub.build.mozilla.org/clobberer/?branch={{clobberer}}" target="_blank">clobberer</a>
<a href="https://secure.pub.build.mozilla.org/clobberer/?branch={{name}}" target="_blank">clobberer</a>
</li>

</ul>

0 comments on commit a481017

Please sign in to comment.