Skip to content

Commit

Permalink
Bug 1252203 - Add some release blocker features to the e10s dashboard
Browse files Browse the repository at this point in the history 
* Allow to filter results to exclude results which wouldn't block the
  release
* Link to wiki page outlining blocker criteria
  • Loading branch information
@wlach
wlach committed Feb 29, 2016
1 parent 75261b7 commit d4732ac
Show file tree
Hide file tree
Showing 6 changed files with 76 additions and 20 deletions.
40 changes: 35 additions & 5 deletions ui/js/controllers/perf/e10s.js
View file
Expand Up @@ -7,6 +7,33 @@ perf.controller('e10sCtrl', [
ThOptionCollectionModel, PhSeries, PhCompare, thServiceDomain) {
var projectName = 'mozilla-inbound';
var interval = 86400*2;
var blockers = {
"cart summary": 2.0,
"damp summary": 2.0,
"dromaeo_css summary": 2.0,
"dromaeo_dom summary": 2.0,
"glterrain summary": 5.0,
"kraken summary": 2.0,
"sessionrestore": 5.0,
"sessionrestore_no_auto_restore": 5.0,
"tart summary": 5.0,
"tcanvasmark summary": 5.0,
"tp5o % Processor Time": 2.0,
"tp5o Main_RSS": 2.0,
"tp5o Modified Page List Bytes": 2.0,
"tp5o Private Bytes": 2.0,
"tp5o XRes": 2.0,
"tp5o responsiveness": 2.0,
"tp5o summary": 5.0,
"tp5o_scroll summary": 2.0,
"tpaint": 5.0,
"tps summary": 5.0,
"tresize": 5.0,
"ts_paint": 2.0,
"tscrollx": 2.0,
"tsvgr_opacity summary": 5.0,
"tsvgx summary": 5.0
};

$scope.testList = [];
$scope.dataLoading = true;
Expand All @@ -18,17 +45,20 @@ perf.controller('e10sCtrl', [
showOnlyImportant: Boolean($stateParams.showOnlyImportant !== undefined &&
parseInt($stateParams.showOnlyImportant)),
showOnlyConfident: Boolean($stateParams.showOnlyConfident !== undefined &&
parseInt($stateParams.showOnlyConfident))
parseInt($stateParams.showOnlyConfident)),
showOnlyBlockers: Boolean($stateParams.showOnlyBlockers !== undefined &&
parseInt($stateParams.showOnlyBlockers))
};

$scope.$watchGroup(['filterOptions.filter',
'filterOptions.showOnlyImportant',
'filterOptions.showOnlyConfident'],
'filterOptions.showOnlyConfident',
'filterOptions.showOnlyBlockers'],
function() {
$state.transitionTo('e10s', {
filter: $scope.filterOptions.filter,
showOnlyImportant: Boolean($scope.filterOptions.showOnlyImportant) ? 1 : undefined,
showOnlyConfident: Boolean($scope.filterOptions.showOnlyConfident) ? 1 : undefined
showOnlyConfident: Boolean($scope.filterOptions.showOnlyConfident) ? 1 : undefined,
showOnlyBlockers: Boolean($scope.filterOptions.showOnlyBlockers) ? 1 : undefined
}, {
location: true,
inherit: true,
Expand Down Expand Up @@ -90,7 +120,7 @@ perf.controller('e10sCtrl', [
if (e10sSig && baseSig) {
var cmap = PhCompare.getCounterMap(
testName, resultsMap['base'][baseSig],
resultsMap['e10s'][e10sSig]);
resultsMap['e10s'][e10sSig], blockers);
cmap.name = platform + ' ' + (platform === 'osx-10-10' ? 'opt' : 'pgo');
cmap.links = [{
title: 'graph',
Expand Down
15 changes: 10 additions & 5 deletions ui/js/directives/perf/compare.js
View file
Expand Up @@ -13,7 +13,8 @@ treeherder.directive(
compareResults: '=',
testList: '=',
filterOptions: '=',
filterByFramework: '@'
filterByFramework: '@',
releaseBlockerCriteria: '@'
},
link: function(scope, element, attrs) {
if (!scope.baseTitle) {
Expand All @@ -28,10 +29,12 @@ treeherder.directive(
return !matchText || item.toLowerCase().indexOf(matchText.toLowerCase()) > (-1);
}
function shouldBeShown(result) {
return (!scope.filterByFramework || _.isUndefined(scope.filterOptions.framework) ||
return (!scope.filterByFramework ||
_.isUndefined(scope.filterOptions.framework) ||
result.frameworkId === scope.filterOptions.framework.id) &&
(!scope.filterOptions.showOnlyImportant || result.isMeaningful) &&
(!scope.filterOptions.showOnlyConfident || result.isConfident);
(!scope.filterOptions.showOnlyConfident || result.isConfident) &&
(!scope.filterOptions.showOnlyBlockers || result.isBlocker);
}
function filterResult(results, key) {
if (_.isUndefined(scope.filterOptions.filter)) {
Expand Down Expand Up @@ -60,9 +63,11 @@ treeherder.directive(
}

scope.$watchGroup([
'filterOptions.framework', 'filterOptions.filter',
'filterOptions.framework',
'filterOptions.filter',
'filterOptions.showOnlyImportant',
'filterOptions.showOnlyConfident'],
'filterOptions.showOnlyConfident',
'filterOptions.showOnlyBlockers'],
function() {
updateFilteredTestList();
});
Expand Down
11 changes: 10 additions & 1 deletion ui/js/perf.js
View file
Expand Up @@ -322,6 +322,7 @@ perf.factory('PhCompare', [ '$q', '$http', 'thServiceDomain', 'PhSeries',
// - .newIsBetter // is new result better or worse (even if unsure)
// - .isImprovement // is new result better + we're confident about it
// - .isRegression // is new result worse + we're confident about it
// - .isBlocker // new result matches "blocker" criteria
// - .delta
// - .deltaPercentage
// - .confidence // t-test value
Expand All @@ -332,7 +333,7 @@ perf.factory('PhCompare', [ '$q', '$http', 'thServiceDomain', 'PhSeries',
// - .className
// - .magnitude
// - .marginDirection
getCounterMap: function getDisplayLineData(testName, originalData, newData) {
getCounterMap: function getDisplayLineData(testName, originalData, newData, blockerCriteria) {

function removeZeroes(values) {
return _.filter(values, function(v){
Expand Down Expand Up @@ -433,6 +434,14 @@ perf.factory('PhCompare', [ '$q', '$http', 'thServiceDomain', 'PhSeries',
}
cmap.isRegression = (cmap.className == 'compare-regression');
cmap.isImprovement = (cmap.className == 'compare-improvement');
if (!_.isUndefined(blockerCriteria) &&
!_.isUndefined(blockerCriteria[testName]) &&
cmap.isRegression &&
cmap.deltaPercentage > blockerCriteria[testName]) {
cmap.isBlocker = true;
} else {
cmap.isBlocker = false;
}
cmap.isMeaningful = (cmap.className != "");
cmap.isComplete = (cmap.originalRuns.length &&
cmap.newRuns.length);
Expand Down
2 changes: 1 addition & 1 deletion ui/js/perfapp.js
View file
Expand Up @@ -35,7 +35,7 @@ perf.config(function($compileProvider, $httpProvider, $stateProvider, $urlRouter
}).state('e10s', {
title: 'e10s talos dashboard',
templateUrl: 'partials/perf/e10s.html',
url: '/e10s?&filter&showOnlyImportant&showOnlyConfident',
url: '/e10s?&filter&showOnlyImportant&showOnlyConfident&showOnlyBlockers',
controller: 'e10sCtrl'
});

Expand Down
6 changes: 6 additions & 0 deletions ui/partials/perf/comparetable.html
View file
Expand Up @@ -19,6 +19,12 @@
Hide uncertain results
</label>
</div>
<div ng-if="releaseBlockerCriteria" class="checkbox">
<label>
<input type="checkbox" ng-model="filterOptions.showOnlyBlockers"/>
Show only regressions blocking release
</label>
</div>
</form>
<hr/>
<table class="table table-condensed compare-table" style="table-layout: fixed;" ng-repeat="compareResults in filteredResultList | orderBy: 'testName'">
Expand Down
22 changes: 14 additions & 8 deletions ui/partials/perf/e10s.html
View file
Expand Up @@ -11,13 +11,19 @@ <h1>Perfherder e10s dashboard</h1>
will take a while to be reflected in results. When in doubt, check the graphs
by hovering over each line.
</p>
<ph-compare-table
base-title="non-e10s"
new-title="e10s"
titles="titles"
test-list="testList"
compare-results="compareResults"
filter-options="filterOptions">
</ph-compare-table>
<p>For more information on what is considered "acceptable" in terms of a Talos
regression, see
<a href="https://wiki.mozilla.org/index.php?title=Electrolysis/Release_Criteria">
the official e10s release criteria</a>.
</p>
<ph-compare-table
base-title="non-e10s"
new-title="e10s"
titles="titles"
test-list="testList"
compare-results="compareResults"
filter-options="filterOptions"
release-blocker-criteria="1">
</ph-compare-table>
</div>
</div>

0 comments on commit d4732ac

Please sign in to comment.