Bug 1413156 - Convert from lodash bind to native ES6 (#3536)

mozilla · May 10, 2018 · dc2a2e2 · dc2a2e2
1 parent be3c6e8
commit dc2a2e2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/ui/js/services/pinboard.js b/ui/js/services/pinboard.js
@@ -130,7 +130,7 @@ treeherder.factory('thPinboard', [
                     }
                 }
 
-                _.each(pinnedJobs, _.bind(saveClassification, classification));
+                _.each(pinnedJobs, saveClassification.bind(classification));
                 $rootScope.$emit(thEvents.jobsClassified, { jobs: pinnedJobsClone });
 
                 _.each(pinnedJobs, saveBugs);
@@ -141,7 +141,7 @@ treeherder.factory('thPinboard', [
 
             // save the classification only on all pinned jobs
             saveClassificationOnly: function (classification) {
-                _.each(pinnedJobs, _.bind(saveClassification, classification));
+                _.each(pinnedJobs, saveClassification.bind(classification));
                 $rootScope.$emit(thEvents.jobsClassified, { jobs: pinnedJobs });
             },
 

diff --git a/ui/plugins/pinboard.js b/ui/plugins/pinboard.js
@@ -1,5 +1,4 @@
 import $ from 'jquery';
-import _ from 'lodash';
 import Mousetrap from 'mousetrap';
 
 import treeherder from '../js/treeherder';
@@ -255,7 +254,7 @@ treeherder.controller('PinboardCtrl', [
                 // Rebind escape to canceling the bug entry, pressing escape
                 // again will close the pinboard as usual.
                 Mousetrap.bind('escape', function () {
-                    const cancel = _.bind($scope.toggleEnterBugNumber, $scope, false);
+                    const cancel = $scope.toggleEnterBugNumber.bind($scope, false);
                     $scope.$evalAsync(cancel);
                 });