Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1228154 - Generate new performance alerts as data is ingested #1177

Merged
merged 2 commits into from Dec 2, 2015
Merged

Bug 1228154 - Generate new performance alerts as data is ingested #1177

merged 2 commits into from Dec 2, 2015

Conversation

wlach
Copy link
Contributor

@wlach wlach commented Nov 26, 2015

Review on Reviewable

@wlach wlach force-pushed the 1228154 branch 2 times, most recently from f4af40d to 7fa5abe Compare November 27, 2015 18:24
@edmorley
Copy link
Contributor

Review status: 0 of 5 files reviewed at latest revision, 2 unresolved discussions.

bin/run_celery_worker, line 22 [r1] (raw file):
This needs a corresponding Procfile entry too :-)

treeherder/config/settings.py, line 196 [r1] (raw file):
Probably don't need to wrap, but up to you.
Let's leave a trailing comma however, to reduce diff size in future.

Comments from the review on Reviewable.io

@wlach wlach force-pushed the 1228154 branch 8 times, most recently from 81c67f1 to d1fcbb5 Compare December 2, 2015 18:00
@wlach
Copy link
Contributor Author

wlach commented Dec 2, 2015

I think we're done here.

Reviewed 6 of 6 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

@wlach wlach merged commit a8e663d into mozilla:master Dec 2, 2015
@wlach wlach deleted the 1228154 branch December 2, 2015 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@wlach @edmorley