Bug 1278711 - Job detail unique together idx #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| operations = [ | ||
| migrations.RunSQL( | ||
| # Using ALTER IGNORE so that it will automatically delete duplicates | ||
| ("ALTER IGNORE TABLE `job_detail` ADD CONSTRAINT " |
There was a problem hiding this comment.
I'll be deleting duplicates with a manual SQL command, but this is a fallback in case there are any new that arrived between cleaning and running this migration. Or if people have dupes on their local machine.
There was a problem hiding this comment.
This is definitely the sort of thing that you're going to want to run manually on prod, then fake the migration :)
camd
changed the title
| @@ -615,6 +615,7 @@ class JobDetail(models.Model): | |||
|
|
|||
| class Meta: | |||
| db_table = "job_detail" | |||
| unique_together = ["title", "value", "job"] | |||
There was a problem hiding this comment.
I think ("title", "value", "job") syntax gives a better hint that this is a single group, though there is no functional difference.
camd
force-pushed
the
job_detail_unique_together_idx
branch
from
77110fd
to
ebed5f8
Compare
camd
force-pushed
the
job_detail_unique_together_idx
branch
from
ebed5f8
to
336dd34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one piggy-backs on the previous PR for bug 1278711, so it is in the same branch. So please just compare using the latest commit.
This change is