Bug1413156 - lodash to ES6: replace _.without _.values _.last usage #3338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks for the PRs! I've requested review from Cameron :-) |
camd
suggested changes
Mar 15, 2018
ui/job-view/PushList.jsx
Outdated
| @@ -165,7 +165,7 @@ export default class PushList extends React.Component { | |||
| // since we fetched more pushes, we need to persist the | |||
| // push state in the URL. | |||
| const rsArray = this.ThResultSetStore.getPushArray(); | |||
| const updatedLastRevision = _.last(rsArray).revision; | |||
| const updatedLastRevision = rsArray.slice(-1)[0].revision; | |||
There was a problem hiding this comment.
I would prefer to just use ``rsArray[rsArray.length -1] for this
ui/js/controllers/main.js
Outdated
| @@ -212,7 +212,9 @@ treeherderApp.controller('MainCtrl', [ | |||
| */ | |||
|
|
|||
| $scope.isSingleTierSelected = function () { | |||
| return _.without(_.values($scope.tiers), false).length === 1; | |||
| return Object.values($scope.tiers).filter(function (value) { | |||
There was a problem hiding this comment.
let's use the more terse ES6 syntax like:
return Object.values($scope.tiers).filter(value => (value !== false)).length === 1;
ui/js/models/repository.js
Outdated
| @@ -278,7 +278,7 @@ treeherder.factory('ThRepositoryModel', [ | |||
|
|
|||
| // To get the current repo to display first, we must | |||
| // ensure it's added to the array last, as per normal user interaction | |||
| storedWatched = _.without(storedWatched, options.name); | |||
| storedWatched = storedWatched.filter(function (value) { return value !== options.name; }); | |||
There was a problem hiding this comment.
Again, this could be:
storedWatched.filter(value => (value !== options.name));
ui/js/models/resultsets_store.js
Outdated
| @@ -364,7 +364,7 @@ treeherder.factory('ThResultSetStore', [ | |||
| } | |||
|
|
|||
| repoData.pushes.sort(rsCompare); | |||
| repoData.rsMapOldestTimestamp = _.last(repoData.pushes).push_timestamp; | |||
| repoData.rsMapOldestTimestamp = repoData.pushes.slice(-1)[0].push_timestamp; | |||
There was a problem hiding this comment.
let's use repoData.pushes.length - 1 again here as above.
ui/js/services/jobfilters.js
Outdated
| @@ -296,7 +296,9 @@ treeherder.factory('thJobFilters', [ | |||
| if (value) { | |||
| const oldQsVal = _getFiltersOrDefaults(field); | |||
| if (oldQsVal && oldQsVal.length) { | |||
| newQsVal = _.without(oldQsVal, value); | |||
| newQsVal = oldQsVal.filter(function (filterValue) { | |||
There was a problem hiding this comment.
let's use ES6 syntax here again, as above
Bug1413156 - lodash to ES6: replace _.without _.values _.last usage Bug1413156 - lodash to ES6: replace _.without _.values _.last usage
Dottori
force-pushed
the
bug1413156-without-values-last
branch
from
b6e26c3
to
8bacd73
Compare
camd
approved these changes
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug1413156 - lodash to ES6: replace _.without _.values _.last usage