Bug 1445295 - intermittent failures fix #3356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change jobsUrl to include job_id for revision link in Bug Details View table
sarah-clements
force-pushed
the
intermittent_failures
branch
from
90d9740
to
2248569
Compare
camd
suggested changes
Mar 21, 2018
ui/helpers/urlHelper.js
Outdated
| export const jobsUrl = function getJobsUrl(tree, revision) { | ||
| return `https://treeherder.mozilla.org/#/jobs?repo=${tree}&revision=${revision}`; | ||
| export const jobsUrl = function getJobsUrl(tree, revision, jobId) { | ||
| return `https://treeherder.mozilla.org/#/jobs?repo=${tree}&revision=${revision}&selectedJob=${jobId}`; |
There was a problem hiding this comment.
This works to use the same domain as wherever it's running if you use:
return `/#/jobs?repo=${tree}&revision=${revision}&selectedJob=${jobId}`
Then it'll pickup localhost:5000 or stage/prototype, if that's where you are. I think this is preferable. Sorry I missed this in an earlier review. :)
There was a problem hiding this comment.
@camd I saw the hash router making that url a route of intermittents-failure.html (intermittent-failures.html#/jobs...) when we were testing it on prototype, but I realize now it's because I had forgotten the / before the hash. I'll remove the domain and resubmit shortly :)
There was a problem hiding this comment.
I'll be glad when (if?) we can get rid of that hash router... :) Thanks!
remove domain from jobsUrl
camd
approved these changes
Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change jobsUrl to include job_id for revision link in bug details view table