Bug 1453482 - Use d-r-f's APIClient instead of WebTest's TestApp #3439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
changed the title
To avoid unnecessary dependencies, and use a more conventional django-rest-framework testing approach: http://www.django-rest-framework.org/api-guide/testing/#apiclient APIClient has a few API differences: * `.json` -> `.json()` * `.status_int` -> `.status_code` * Get parameters are passed as keyword argument `data` not `params` * The default hostname is `http://testserver` not `http://localhost` * Additional HTTP headers are passed directly as keyword arguments, rather than nested under a `headers` property. * It doesn't check the status code itself, so explicit checks are required, along with removing `expect_errors`. * The `.post_json()` and `.put_json()` methods don't exist. See also the docs for the Django test client (which APIClient wraps): https://docs.djangoproject.com/en/1.11/topics/testing/tools/#the-test-client Whilst making these changes, I also cleaned up the session fetching in `test_auth.py` and `test_backends.py`, and added a `status_code` check in `conftest.py`'s `mock_post_json()` - which makes the root cause of test failures clearer.
camd
approved these changes
Apr 12, 2018
| assert resp.json["id"] == test_job.id | ||
| assert not resp.json.get("taskcluster_metadata") | ||
| assert resp.status_code == 200 | ||
| assert isinstance(resp.json(), dict) |
There was a problem hiding this comment.
I don't know how expensive the call to resp.json() is, but I'd be tempted to set that to a temp var and then act on that. This is such a nit that it really doesn't matter much, just something that jumped out at me. :) Feel free to ignore, if you like. :)
There was a problem hiding this comment.
I don't know how expensive the call to resp.json() is
Ah same thing occurred to me - but I checked it and turns out it's memoized:
https://github.com/django/django/blob/1.11.12/django/test/client.py#L693-L701
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid unnecessary dependencies, and use a more conventional django-rest-framework testing approach:
http://www.django-rest-framework.org/api-guide/testing/#apiclient
APIClient has a few API differences:
.json->.json().status_int->.status_codedatanotparamshttp://testservernothttp://localhostheadersproperty.expect_errors..post_json()and.put_json()methods don't exist.See also the docs for the Django test client (which APIClient wraps):
https://docs.djangoproject.com/en/1.11/topics/testing/tools/#the-test-client
Whilst making these changes, I also cleaned up the session fetching in
test_auth.pyandtest_backends.py, and added astatus_codecheck inconftest.py'smock_post_json()- which makes the root cause of test failures clearer.