Bug 1450030 - Convert top nav bar to ReactJS #3804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camd
force-pushed
the
convert-primary-nav-bar-to-reactjs
branch
from
c70c4b0
to
b9ccba7
Compare
added 3 commits
July 20, 2018 15:38
|
@camd, it seems like a fair few test fix commits have been added? Is there something we can do to improve the testing situation locally to avoid the need to iterate on Travis? (The Travis iteration time will be slower than locally, and GitHub sends an email out with each new commit which is pretty noisy.) |
|
Ahh, sorry about the noise. Yeah, I can wait to create the PR for that. I didn't realize all the noise went to everyone... I should have checked... My bad. I'll close this till I get the intermittent tests passing locally. |
|
No worries! Do say if there's any part of testing locally that's painful - there may be ways I can come up with to improve it :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.