Bug 1505758 - Fix/enable several more ESLint rules #4245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camd
approved these changes
Nov 8, 2018
| @@ -78,6 +78,8 @@ export default class JobButtonComponent extends React.Component { | |||
| const resultStatus = state === 'completed' ? result : state; | |||
| const runnable = state === 'runnable'; | |||
| const btnClass = getBtnClass(resultStatus, failure_classification_id); | |||
| // TODO: This is broken (bug 1504713) | |||
| // eslint-disable-next-line no-restricted-globals | |||
| let title = `${resultStatus} | ${job_type_name} - ${status}`; | |||
There was a problem hiding this comment.
I think we can take - ${status} out of the template here. I can't think of what it was supposed to be at this point, since resultStatus covers both result and state.
There was a problem hiding this comment.
Yeah I agree - I've left a comment on bug 1504713 :-)
(Won't fix here so as to not introduce behaviour changes in this PR)
| ]).then(async (results) => { | ||
|
|
||
| // The first result comes from the job promise. | ||
| ]).then(async ([jobResult, jobDetailResult, jobLogUrlResult, phSeriesResult]) => { |
There was a problem hiding this comment.
Nice... this is a lot clearer now.
| {autoclassifyStatus === 'failed' && <span>Autoclassification failed</span>} | ||
| </div>} | ||
| { | ||
| // TODO: This is broken (bug 1504711) |
There was a problem hiding this comment.
tbh: I'm not certain what the fix is for this. I suppose we'll have to cross this bridge when we address re-enabling the autoclassify tab...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for easier review and links to the ESLint rule docs for each rule.
I've mostly left the Perfherder/log viewer files untouched (using eslint-disable there instead) so as to reduce churn/potential for bugs given they are going to be rewritten soon anyway. The main objective is to ensure our existing newly rewritten JS and even more importantly any about-to-be-written JS has full rule coverage.