Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1525789 - Add commit_revision filter field to /push endpoint #4587

Merged
merged 1 commit into from
Feb 8, 2019

Conversation

camd
Copy link
Contributor

@camd camd commented Feb 7, 2019

This fixes searching for a push by a sub-commit

@camd
Copy link
Contributor Author

camd commented Feb 7, 2019

@sarah-clements : Would you be able to help me identify all the places in Perfherder where we should now be using this filter field? Probably some of the spots using /push endpoint just wants the tip, but others need a sub-commit.

@camd camd temporarily deployed to treeherder-prototype February 7, 2019 23:35 Inactive
@camd camd temporarily deployed to treeherder-prototype February 7, 2019 23:41 Inactive
@camd
Copy link
Contributor Author

camd commented Feb 7, 2019

@sarah-clements and I worked together to get the Push endpoint calls fixed up for the compare chooser. So this is now ready for review.

This fixex searching for a push by a sub-commit
@camd camd force-pushed the fix-search-pushes-by-commit branch from 2ef4a46 to 8badb83 Compare February 7, 2019 23:52
@camd camd temporarily deployed to treeherder-prototype February 7, 2019 23:53 Inactive
Copy link
Contributor

@sarah-clements sarah-clements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

@camd camd merged commit b224460 into master Feb 8, 2019
@camd camd deleted the fix-search-pushes-by-commit branch February 8, 2019 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants